Page MenuHomePhabricator

Resource loader requests are not caching properly
Closed, ResolvedPublic

Description

See the example url. All resources are reloaded again every time (and not even 304 response?)


Version: unspecified
Severity: major
URL: http://translatewiki.net/static/rl.caching.txt

Details

Reference
bz25146

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport set Reference to bz25146.

Can you reproduce this with latest trunk? I fixed a bug where we were setting maxage=123 instead of max-age=123 . Also, if you can still reproduce this, please provide the URL of a page where this occurs.

I think this is fixed now - the code was checking if the If-Modified-Since was exactly equal to the requested modules' maximum modified time, rather than checking if it was less than or equal to. See r72940