Page MenuHomePhabricator

Toolbar API: Removing characters is broken
Closed, ResolvedPublic

Description

Characters can't be removed with removeFromToolbar.

Since r65558, characters are no longer wrapped in an <a> but in a <span>, so the code

if ( typeof data.character == 'string' ) {

// Character
//target += ' a[rel=' + data.character + ']';

from ./js/plugins/jquery.wikiEditor.toolbar.js (line 153) must get changed.

If you want to reproduce the bug just run the test script (./js/tests/wikiEditor.toolbar.js), look at the ":))" after it should have been removed and fix bug 25185 as well.


Version: unspecified
Severity: normal

Details

Reference
bz25186