Currently it's impossible to insert a button with a data-URL as icon into the toolbar. Could you change the autoIcon function such that the path isn't prepended to URLs starting with "data:"? Thanks.
Version: unspecified
Severity: enhancement
Description
Description
Details
Details
- Reference
- bz25223
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Allow data URLs for toolbar icons | mediawiki/extensions/WikiEditor | master | +6 -0 |
Event Timeline
Comment Actions
Keep in mind that data URLs are not universally supported: of the browsers supported by WikiEditor, they break in IE7.
Comment Actions
Right, you would need to support providing a data-URL+file-URL... Seems like it's possible to do, but strange.
Comment Actions
(In reply to comment #1)
Keep in mind that data URLs are not universally supported: of the browsers
supported by WikiEditor, they break in IE7.
If data-URL were only used in personal user scripts this wouldn't be a problem. If a user uses IE7 and puts some code in his vector.js that inserts a toolbar button with a data-URL, it's his own fault.
Comment Actions
Well sure, but toolbar icons would more typically be added through site JS, and people like to copy others' user JS.
Comment Actions
mhershberger wrote:
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment Actions
Well, define "problem". I no longer care about WikiEditor, so for me the missing support for data-URLs is no longer a problem. If anybody else wants to have this feature, then go ahead and implement it, but if nobody else cares, then let the WikiEditor rest in peace and decline this task.
Comment Actions
Change 527946 had a related patch set uploaded (by Happy5214; owner: Happy5214):
[mediawiki/extensions/WikiEditor@master] Allow data URLs for toolbar icons