Page MenuHomePhabricator

Message::params() triggers a fatal error
Closed, ResolvedPublic

Description

trivial patch to solve a fatal error

I had a fatal error while running phpunit tests with r73625.

The cause is that Message::params() incorrectly use func_get_args which can not be used as a second parameter of a function. The bug appears with PHP 5.2.12 (under Mac OS X 1.5).

How to trigger it :
<?php
function f1() {
print_r( array_merge(

array_values( func_get_args() )

)); }

function f2() {
print_r( array_merge(

array(), // push func_get_args as a second parameter
array_values( func_get_args() )

)); }

print "Calling f1:\n";
f1( array() );
print "Calling f2:\n";
f2( array() );

Please find attached a patch that push func_get_args() result in an array.


Version: 1.17.x
Severity: normal

Attached:

Details

Reference
bz25273

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:14 PM
bzimport set Reference to bz25273.
bzimport added a subscriber: Unknown Object (MLST).