Page MenuHomePhabricator

PLURAL suggested for headline messages on page translate move confirmation page
Closed, ResolvedPublic

Description

Section header messages:
pt-movepage-list-pages
pt-movepage-list-translation
pt-movepage-list-section
pt-movepage-list-other
generally should use PLURAL, and not be present when an empty section follows.

But:
Since these messages are mainly seen by administrators, who likely are not that
picky, and tweaking code so as to know the number of section entries in advance
before a section is being computed, is a bit work, and adds to server load, and
having only one entry is usually unlikely, this is a very low priority issue at
present, imho.


Version: unspecified
Severity: enhancement

Details

Reference
bz25274

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:15 PM
bzimport set Reference to bz25274.

This feature is still in "it should work" stage. Should definitively keep this issue in mind when making it better someday.

dev.malkum wrote:

Fixed it by changing the following MessageKeys in PageTranslation.i18n.php

'pt-movepage-list-translation' => 'Translation {{PLURAL:$1|page|pages}}',
'pt-movepage-list-section' => 'Translation unit {{PLURAL:$1|page|pages}}',
'pt-movepage-list-other' => 'Other sub{{PLURAL:$1|page|pages}}',

Also in the tag/SpecialTranslationMovePage.php passed the $count parameter
to the $out->wrapWikiMsg()