Page MenuHomePhabricator

SkinSubPageSubtitle described as taking 2 parameters, but only implements 1
Closed, ResolvedPublic

Description

Author: justin

Description:
The hook SkinSubPageSubtitle is listed as taking in 2 parameters, the Skin object and the Subtitles variable (http://www.mediawiki.org/wiki/Manual:Hooks/SkinSubPageSubtitle). The actual hook only implements the passing of the subtitles variable on (approximately) line 1144 of Skin.php:

if( !wfRunHooks( 'SkinSubPageSubtitle', array( &$subpages ) ) )

Passing the Skin object would prove immensely helpful in the creation of my extension to modify the subpages display, as the mTitle object is protected.

Let me know if you have any questions, or if I missed something in using this hook.
-Justin


Version: 1.16.x
Severity: normal
URL: http://www.mediawiki.org/wiki/Manual:Hooks/SkinSubPageSubtitle

Details

Reference
bz25292

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:16 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz25292.
bzimport added a subscriber: Unknown Object (MLST).