Page MenuHomePhabricator

Link to [[Special:PendingChanges]] from sidebar if logged in user is reviewer
Closed, InvalidPublic

Description

See http://en.wikipedia.org/wiki/Wikipedia:Pending_changes/Feedback/Archive_2#Side_bar_link

It's conceivable that there should be a link in the "Toolbox" for those with Reviewer rights. This issue is about figuring out if it's appropriate.


Version: unspecified
Severity: enhancement
URL: http://en.wikipedia.org/wiki/Wikipedia:Pending_changes/Feedback/Archive_2#Side_bar_link

Details

Reference
bz25298

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:16 PM
bzimport set Reference to bz25298.
bzimport added a subscriber: Unknown Object (MLST).

I don't think so. We don't have actions in the toolbox. I think that if added, It should go as a tab.

Quoting the relevant portion of this email:
http://lists.wikimedia.org/pipermail/wikitech-l/2010-October/049813.html

We're probably not going to address this one in the November 2010
release. If we do it, we need to make it conditional upon whether the
person has reviewer rights. The problem with this one is that we
don't yet have clear guidelines for what belongs in the toolbox on the
left, and whether any of the pending changes special pages rise to the
level of importance that we should put them in the toolbox.

(In reply to comment #2)

Quoting the relevant portion of this email:
http://lists.wikimedia.org/pipermail/wikitech-l/2010-October/049813.html

We're probably not going to address this one in the November 2010
release. If we do it, we need to make it conditional upon whether the
person has reviewer rights.

This is entirely trivial.

The problem with this one is that we
don't yet have clear guidelines for what belongs in the toolbox on the
left,

There aren't any guidelines. Extensions are free to add things to the toolbar.

and whether any of the pending changes special pages rise to the
level of importance that we should put them in the toolbox.

No opinion here one way or the other.

Ok, here's the plan. We'll link from the toolbox to [[Special:PendingChanges]] (nee [[Special:OldReviewedPages]]) *if* the logged in user has review permission.

Unassigning from Brandon for now. Will assign to a developer next time we triage.

Unassigning for now....this might end up going right back to Priyanka

Aside from "Special pages", all of the toolbox items are relevant to the page being viewed. This probably should go elsewhere if anywhere. Maybe even "Special pages" should be moved eventually...

"Upload" is also not specific to the page being viewed. That said, it makes the most sense in proximity to "Recent changes", which is under "Interaction" in Vector, so that seems like the best place to put it, IMHO.

(In reply to comment #7)

"Upload" is also not specific to the page being viewed. That said, it makes
the most sense in proximity to "Recent changes", which is under "Interaction"
in Vector, so that seems like the best place to put it, IMHO.

Maybe Brandon should look at this? Having the link there feels awkward. It might be better under "Interaction" or something.

One problem with using navigation/interaction is that buildSidebar() uses a cache that is only language dependent. Adding the link only for Reviewers would result in cache pollution and wouldn't work.

The toolbox doesn't have this problem, but it's an awkward place though.

pdhanda wrote:

Yeah, I'm not sure how to make the link visible only for reviewers. According to Roan, this is the correct way to customize the sidebar:
https://secure.wikimedia.org/wikipedia/en/w/index.php?title=MediaWiki:Sidebar&action=edit

Priyanka, you don't want to use MediaWiki:Sidebar. That's for user customizing. This would be *the software* adding it.

Is there any demand for this or should it be scrapped or something?

Making this low priority, due to the dependency on making it practical to add new items to the "Interaction" area via extension.

(In reply to comment #12)

Is there any demand for this or should it be scrapped or something?

Closing.