Page MenuHomePhabricator

autoreview privilege should be removeable - like editor
Closed, ResolvedPublic

Description

Author: llampak

Description:
Currently the autoreview group is implicit and cannot be directly removed or granted. It can be removed only indirectly by blocking a user for a second but it's not very elegant solution. IMHO autoreview should work in the same way as editor.

On Polish wikipedia this issue has been one of the reasons against introducing the autoreview group. We should be able to strip a vandal from this privilege or promote a non-vandal.

If you decide to solve this bug, you could use the opportunity to remove the copy-pasted code in checkAutoPromote() and maybeMakeEditor(). Or even better, to have a look at bug 24948.


Version: unspecified
Severity: enhancement

Details

Reference
bz25390

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM
bzimport set Reference to bz25390.
bzimport added a subscriber: Unknown Object (MLST).

Isn't this a configuration issue. You can (already) create a group that revokes autoreview to anyone in the group (Untrusted people). You can also have an assignable autoreview group.(Of course you can't really remove the implicit group, but creating another group that removes the same privileges amounts to the same thing imho)

For example, on enwikinews, only people in the bot group have autoreview, and you can't get autoreview unless you are a bot.

llampak wrote:

Yeah, but I would treat it more like a workaround for current software limitations rather that a real solution. It's against intuition and excessively complicated (three groups instead of one) and as such has no chance of getting approval of any wiki community (they're saying one new group would be too many, I won't try with three). If it were a neat solution the editor group would work this way but because of some good reasons it doesn't.

Marking this one as blocked by bug 24948, since it doesn't make sense to add a lot of new code in this area without first getting the functionality into the core somehow.

llampak wrote:

I've made another bug report: bug 25428. And changed the block for dependency - if both bugs are done, this one shouldn't be a problem (I hope).

So this is about users that had the implicit group and were once blocked or is it more general? For, now the block log can be checked until more is done.