Page MenuHomePhabricator

PHP Notice: Undefined index: editfont in /includes/ResourceLoaderModule.php on line 968
Closed, ResolvedPublic

Description

Per summary: PHP Notice: Undefined index: editfont in /www/w/includes/ResourceLoaderModule.php on line 968

Seen on Translatewiki.


Version: unspecified
Severity: normal

Details

Reference
bz25416

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:11 PM
bzimport set Reference to bz25416.

Siebrand reported this too, but I have no idea why it's happening. I can't reproduce it, and from looking at the code it should be impossible.

'editfont' is defined in $wgDefaultUserOptions , so unless your config overwrites that var I don't see how 'editfont' could not be in the options array for a given user.

cnit wrote:

I have the same notice with latest 1.17 trunk, too. I don't have $wgDefaultUserOptions overriden anywhere in LocalSettings.php, or that is somewhere else? My test wiki (for development purposes) was 1.16 trunk, now svn update'd to 1.17 trunk then 'php update.php'. Why don't just check array index with isset() or suppress with @ ? Extra warnings in error.log are not a good thing.

We haven't run the preferences conversion script, so there might still be some old style preferences in the database. Could that affect it?

(In reply to comment #3)

We haven't run the preferences conversion script, so there might still be some
old style preferences in the database. Could that affect it?

I think that might just be it. That'd be a bug in the preferences rewrite. Will investigate.

There seems to have been a bug in the backwards compatibility code for old-style preferences, which I hope to have fixed in r74625. Could you test with that rev and see if the warnings go away?

cnit wrote:

I've updated to r74716 and the warning went away. Thank you, Roan!