ngautam wrote:

Do we use "mode" in the function? This fixes the issue:

<code>
var rewrite_url = function() {
var url = '{{{banner-url-2010}}}?utm_medium=sitenotice&utm_campaign={{{campaign}}}&utm_source={{{banner}}}';

var targets = String( '{{{targets}}' ).split(',');
if ( targets.length ) {

url += '&' + targets[Math.floor( Math.random() * targets.length )].replace(/^\s+|\s+$/, '');

}
$j(".fundraiser-banner a.variable_lp").attr("href",url);
}
$j(document).ready(rewrite_url);
</code>

Also, in order to invoke this, the link needs to have the class "varialbe_lp" appended to it, so it will look like this <a class="variable_lp">{{{donate-text2}}}</a>

ngautam wrote:

Addendum...just to be super-safe, let's have it be this:
<code>
var rewrite_url = function() {
var url =
'{{{banner-url-2010}}}?utm_medium=sitenotice&utm_campaign={{{campaign}}}&utm_source={{{banner}}}';

var targets = String( '{{{targets}}' ).split(',');
if ( targets.length ) {

url += '&' + targets[Math.floor( Math.random() * targets.length

)].replace(/^\s+|\s+$/, '');
}
$j(".fundraiser-banner a.variable_lp").attr("href",url);
}
if($j){
$j(document).ready(rewrite_url);
}
</code>

and put a default URL into the banner pointing to something sensible, like https://payments.wikimedia.org/index.php/Special:PayflowProGateway

I'm re-opening this as our current solution is starting to clutter up our JS. Can we get this into the CN interface?

If we were to implement this in a sane way it would involve added fundraising specific user-interface components to CentralNotice, something we haven't done yet. Is it OK to make CentralNotice that Wikimedia specific?

This has been fixed in all the banners I know about. If we want to add some UI for this, a new bug should be opened.