Page MenuHomePhabricator

Export header should not be shown if no pages were requested, to reduce confusion
Closed, ResolvedPublic

Description

When I call the url I get only the header of the export, but no page content. The pages are in a list.

I am not sure, should that query give a full export of the pages or is the export header added wrongly to the output?

Works fine with generator=allpages: http://de.wikipedia.org/w/api.php?action=query&generator=allpages&gaplimit=5&gapprefix=User&gapnamespace=10&export

Thanks.


Version: unspecified
Severity: normal
URL: http://de.wikipedia.org/w/api.php?action=query&list=allpages&aplimit=5&apprefix=User&apnamespace=10&export

Details

Reference
bz25463

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:14 PM
bzimport set Reference to bz25463.

This is expected behavior: the export parameter only operates on pages specified in &titles/&pageids/&revids or pages generated by a generator. It can't operate on 'normal' module results, because modules in non-generator mode don't return Title objects to the query module, like they do in generator mode.

If this isn't documented clearly, I guess the docs should be improved.

Thanks for the explanation.

But is is a good idea to add the export header in this case? I do not think so, because it assume there is something wrong, and a export is possible.

(In reply to comment #2)

Thanks for the explanation.

But is is a good idea to add the export header in this case? I do not think so,
because it assume there is something wrong, and a export is possible.

You're right about that one. Reopening and repurposing bug.

Created attachment 7752
no export header, when no titles to export

A condition which count the titles to export is missing, I have added a condition in the attachment

Feel free to modify the patch or create a new one.

attachment bug25463.patch ignored as obsolete

I can't get this to apply cleanly on SVN Head.

Not sure if it's my computer at fault

(In reply to comment #5)

I can't get this to apply cleanly on SVN Head.
Not sure if it's my computer at fault

Works fine for me, when apply to trunk/phase3. Maybe remove folder from Index and apply to the parent of ApiQuery.php.

reedy@reedy-laptop:~/mediawiki/trunk/phase3$ patch -p0 -i bug25463.patch
(Stripping trailing CRs from patch.)
patching file includes/api/ApiQuery.php
Hunk #1 FAILED at 457.
1 out of 1 hunk FAILED -- saving rejects to file includes/api/ApiQuery.php.rej
reedy@reedy-laptop:~/mediawiki/trunk/phase3$

Any chance you could just run me another copy of the patch as is?

I'll also try it on Windows when I get gome in a few

Created attachment 7760
no export header, when no titles to export - 2

maybe r75308 broke the patch, I have create a new one

Attached:

Cheers, that applies cleanly and looks good

r75554

Minor tweak, but just about the same :)

Thanks!