Page MenuHomePhabricator
Create Task
Maniphest T27471

Add "Delete associated talk page" option to action=delete
Closed, ResolvedPublic2 Estimated Story PointsFeature
Actions

Description

In the action=delete form there should be a checkbox that allows the user to delete the associated talk page of non-talk pages.

Details

Reference
bz25471
SubjectRepoBranchLines +/-
DeleteAction: Add "Delete associated talk page" option to the formmediawiki/coremaster+64 -12
DeletePage: add option to delete the associated talk pagemediawiki/coremaster+283 -74
WIP: Allow deleting associated page from deletion interfacemediawiki/coremaster+171 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Alfa80 subscribed.Sep 29 2019, 6:16 PM
daniel added subscribers: CCicalese_WMF, daniel.Oct 1 2019, 2:47 PM

Tagging Platform Engineering and pinging @CCicalese_WMF for PM review.

CCicalese_WMF added a project: Platform Engineering.Nov 8 2019, 10:56 PM
CCicalese_WMF moved this task from Inbox to Feature Requests to Review on the Platform Engineering board.
• eprodromou lowered the priority of this task from Medium to Low.Nov 26 2019, 4:09 PM
• eprodromou moved this task from Feature Requests to Review to Tracking/Watching on the Platform Engineering board.
• eprodromou subscribed.

Although this feature seems relatively easy and valuable, it's been sitting in our queue for almost 10 years. It makes sense for us in CPT to see the flag changed. However, we think that should be decoupled from a complete re-architecture of the deletion process, which is a conversation that should probably have its own ticket and/or RFC.

John_Broughton subscribed.Nov 30 2019, 3:30 AM
1997kB moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Dec 24 2019, 2:02 PM
1997kB moved this task from Special:Contributions / Special:DeletedContributions to To triage on the MediaWiki-Special-pages board.Dec 24 2019, 2:27 PM
Ammarpad claimed this task.May 16 2020, 9:02 AM
Ammarpad raised the priority of this task from Low to Medium.
gerritbot added a comment.Jun 15 2020, 12:29 AM

Change 605433 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] WIP: Allow deleting associated page from deletion interface

https://gerrit.wikimedia.org/r/605433

gerritbot added a project: Patch-For-Review.Jun 15 2020, 12:29 AM
Ammarpad added a comment.Jul 10 2020, 2:57 PM

I will finish and put this for review after the branch cut.

DannyS712 changed the status of subtask T233987: Convert deletion from action page to new `Special:Delete` from Open to Stalled.Jul 10 2020, 3:09 PM
AlexisJazz mentioned this in T263211: Add "Restore associated talk page" option to special:undelete.Sep 17 2020, 10:57 PM
AlexisJazz awarded a token.EditedSep 17 2020, 11:21 PM
AlexisJazz subscribed.
In T27471#6296992, @Ammarpad wrote:

I will finish and put this for review after the branch cut.

I just looked this up because I need something related. What a coincidence it is just now being worked on.

I need this in the API though, and for undeletion: T263209. I also opened a ticket for the same feature on Special:Undelete: T263211.

Ammarpad mentioned this in T263209: Add "delete associated talk page" option to ApiDelete.Sep 18 2020, 4:54 AM
gerritbot added a comment.Nov 25 2020, 9:07 AM

Change 605433 abandoned by Ammarpad:
[mediawiki/core@master] WIP: Allow deleting associated page from deletion interface

Reason:
A lot of things have changed, needs new strategy

https://gerrit.wikimedia.org/r/605433

Ammarpad added a comment.Nov 25 2020, 9:11 AM

In Community Wishlist https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2021/Admins_and_patrollers/(Un)delete_associated_talk_page

Firestar464 subscribed.Dec 9 2020, 1:19 AM

Should this thing be moved to high priority, per this proposal?

Reedy added a comment.Dec 9 2020, 1:26 AM
In T27471#6678229, @Firestar464 wrote:

Should this thing be moved to high priority, per this proposal?

No.

https://www.mediawiki.org/wiki/Phabricator/Project_management#Priority_levels

High – Someone is working or planning to work on this task soon.

Maybe if it wins and gets approved.

Ammarpad removed Ammarpad as the assignee of this task.Apr 1 2021, 3:50 PM
Ammarpad subscribed.
Ammarpad unsubscribed.
Maintenance_bot removed a project: Patch-For-Review.Apr 1 2021, 4:11 PM
DannyS712 mentioned this in T285514: (Un)delete associated talk page (spike).Jun 25 2021, 3:25 AM
Daimona added a project: Undelete-Associated-Talk-Page (2021).Aug 5 2021, 6:33 PM
ldelench_wmf added a project: Community-Tech.Aug 10 2021, 8:06 PM
ldelench_wmf moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.
Daimona updated the task description. (Show Details)Sep 2 2021, 12:09 AM
Daimona set the point value for this task to 2.
Daimona moved this task from Needs Discussion to Up Next (May 6-17) on the Community-Tech board.
Daimona added a subtask: T263209: Add "delete associated talk page" option to ApiDelete.
Daimona removed a subtask: T233987: Convert deletion from action page to new `Special:Delete`.
Daimona changed the subtype of this task from "Task" to "Feature Request".Sep 2 2021, 12:12 AM
Daimona subscribed.
Krinkle removed a project: MediaWiki-Special-pages.Oct 13 2021, 7:28 PM
Krinkle removed a subscriber: • wikibugs-l-list.
Daimona claimed this task.Oct 21 2021, 12:53 PM
Daimona edited projects, added Community-Tech (CommTech-Sprint-11); removed Community-Tech.
Daimona moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-11) board.
ldelench_wmf moved this task from CommTech-Sprint-11 to CommTech-Sprint-12 on the Community-Tech board.Oct 25 2021, 8:01 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-12); removed Community-Tech (CommTech-Sprint-11).
ldelench_wmf moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-12) board.
ldelench_wmf moved this task from CommTech-Sprint-12 to CommTech-Sprint-13 on the Community-Tech board.Nov 8 2021, 9:58 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-13); removed Community-Tech (CommTech-Sprint-12).
ldelench_wmf moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-13) board.
ldelench_wmf added a parent task: T295389: [EPIC] User-facing changes for (Un)delete associated talk page.Nov 9 2021, 5:53 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-14); removed Community-Tech (CommTech-Sprint-13).Nov 22 2021, 9:35 PM
ldelench_wmf moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-14) board.Nov 22 2021, 9:36 PM
gerritbot added a comment.Nov 30 2021, 4:46 PM

Change 715954 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] DeletePage: add option to delete the associated talk page

https://gerrit.wikimedia.org/r/715954

gerritbot added a project: Patch-For-Review.Nov 30 2021, 4:46 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-15); removed Community-Tech (CommTech-Sprint-14).Dec 3 2021, 7:50 PM
ldelench_wmf moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-15) board.Dec 3 2021, 7:51 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-16); removed Community-Tech (CommTech-Sprint-15).Jan 4 2022, 5:08 PM
ldelench_wmf moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-16) board.Jan 4 2022, 5:10 PM
gerritbot added a comment.Jan 16 2022, 3:00 AM

Change 715954 merged by jenkins-bot:

[mediawiki/core@master] DeletePage: add option to delete the associated talk page

https://gerrit.wikimedia.org/r/715954

Maintenance_bot removed a project: Patch-For-Review.Jan 16 2022, 3:10 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 16 2022, 4:00 AM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-17); removed Community-Tech (CommTech-Sprint-16).Jan 18 2022, 8:13 PM
ldelench_wmf moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-17) board.Jan 18 2022, 8:21 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-18); removed Community-Tech (CommTech-Sprint-17).Jan 31 2022, 2:33 PM
ldelench_wmf moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-18) board.Jan 31 2022, 2:36 PM
Daimona moved this task from Backlog to 🌟Top Priority on the Undelete-Associated-Talk-Page (2021) board.Feb 1 2022, 10:39 AM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-19); removed Community-Tech (CommTech-Sprint-18).Feb 15 2022, 10:22 PM
• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-19) board.Feb 15 2022, 10:31 PM
• JMcLeod_WMF removed a project: Community-Tech (CommTech-Sprint-19).Mar 1 2022, 6:44 PM
• JMcLeod_WMF added a project: Community-Tech (CommTech-Sprint-20).Mar 1 2022, 6:53 PM
• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-20) board.Mar 1 2022, 7:01 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-21); removed Community-Tech (CommTech-Sprint-20).Mar 16 2022, 12:17 PM
• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-21) board.Mar 16 2022, 12:23 PM
dmaza claimed this task.Mar 24 2022, 3:49 AM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-22); removed Community-Tech (CommTech-Sprint-21).Mar 28 2022, 2:41 PM
• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-22) board.Mar 28 2022, 2:44 PM
dmaza moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-22) board.Mar 28 2022, 3:09 PM
gerritbot added a comment.Apr 1 2022, 5:52 PM

Change 741717 had a related patch set uploaded (by Dmaza; author: Daimona Eaytoy):

[mediawiki/core@master] DeleteAction: Add "Delete associated talk page" option to the form

https://gerrit.wikimedia.org/r/741717

gerritbot added a project: Patch-For-Review.Apr 1 2022, 5:52 PM
• NRodriguez closed subtask T263209: Add "delete associated talk page" option to ApiDelete as Resolved.Apr 4 2022, 6:08 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-23); removed Community-Tech (CommTech-Sprint-22).Apr 11 2022, 2:44 PM
• JMcLeod_WMF moved this task from Ready 🎬 to Review / Feedback 💬 on the Community-Tech (CommTech-Sprint-23) board.Apr 11 2022, 2:47 PM
gerritbot added a comment.Apr 18 2022, 3:59 PM

Change 741717 merged by jenkins-bot:

[mediawiki/core@master] DeleteAction: Add "Delete associated talk page" option to the form

https://gerrit.wikimedia.org/r/741717

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 18 2022, 4:00 PM
MusikAnimal moved this task from Review / Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-23) board.Apr 18 2022, 4:26 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 18 2022, 4:30 PM
dom_walden moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-23) board.Apr 19 2022, 1:14 PM
dom_walden subscribed.

I have tested the new "Delete associated talk page" checkbox when deleting via the UI. I only did relatively basic tests as a lot has been tested in the API portion of this work.

I have tested deleting and suppressing files (+ their respective file_talk pages) and user pages (+ user_talk pages).

I also tested that I could not delete if I am blocked from the talk page.

I checked logstash for any errors.

Test environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.39.0-alpha (108cd5b) 11:35, 19 April 2022.

Amorymeltzer subscribed.Apr 20 2022, 1:20 PM
• NRodriguez closed this task as Resolved.Apr 21 2022, 4:09 PM
• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-23) board.Apr 25 2022, 2:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL