Page MenuHomePhabricator

Incorrect method call
Closed, ResolvedPublic

Description

Author: b.manolov

Description:
A trivial patch

The method updateModule from MessageBlobStore is defined as follows:

updateModule($name, ResourceLoaderModule $module, $lang = null)

but on MessageBlobStore:333 it is called as

updateModule($module, $lang)

Apparently the first argument $name is missing.

A patch is attached.


Version: 1.17.x
Severity: critical

Attached:

Details

Reference
bz25474

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:15 PM
bzimport set Reference to bz25474.

b.manolov wrote:

(In reply to comment #1)

See r74525.

Please take a closer look at the updateModule call. Currently it results in a fatal error:

Catchable fatal error: Argument 2 passed to MessageBlobStore::updateModule() must be an instance of ResourceLoaderModule, string given, called in mediawiki/includes/MessageBlobStore.php on line 333 and defined in mediawiki/includes/MessageBlobStore.php on line 121

Thanks for the patch, applied in r74614.