Page MenuHomePhabricator

Dialogs broken in deployed wikieditor
Closed, DeclinedPublic

Description

It seems that some of the JS in deployment uses $ now instead of $j and I think that this is related. I get the error

plugins.combined.min.js:126
TypeError: Result of expression '$j.wikiEditor' [undefined] is not an object.


Version: unspecified
Severity: major

Details

Reference
bz25479

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:16 PM
bzimport set Reference to bz25479.

(In reply to comment #0)

It seems that some of the JS in deployment uses $ now instead of $j and I think
that this is related. I get the error

The jQuery 1.4 migration was completed this morning, some 20 hours after your report. Prior to that, the last change to deployed JS was on October 4, and the last change that seems like it could be remotely related was on September 13.

plugins.combined.min.js:126
TypeError: Result of expression '$j.wikiEditor' [undefined] is not an object.

That's strange, where are you getting that exactly?

I got it yesterday on English Wikipedia, several minutes before the opening of the bug. The problem was at all dialogs and on multiple pages. It seems gone now.

Could be caused by site JS maybe, or maybe it's just a fluke (JS file failed to load or something). Closing as WORKSFORME unless and until someone can reproduce.