Page MenuHomePhabricator

Height of textarea in Share dialog of video player
Closed, ResolvedPublic

Assigned To
None
Authored By
TheDJ
Oct 11 2010, 10:29 PM
Referenced Files
F7169: Screen_shot_2010-10-22_at_15.19.57.png
Nov 21 2014, 11:17 PM
F7168: mwEmbed_share_screen.png
Nov 21 2014, 11:17 PM
F7170: share_increased_textarea.png
Nov 21 2014, 11:17 PM
Subscribers

Description

For me on Safari the size of that textarea is might small (always has been, never thought to mention it before).

My CSS style there for .mv-player .overlay-win textarea {} says "height:15px", which isn't really readable.

I also note it has "width: 100%", but that is not really ok, because 100% of the parent div is larger than the available width due to padding in the parent. Suggest using columns and hoping for the best, or otherwise calculating a suited width based on the higher parent with class="overlay-win ui-state-default ui-widget-header ui-corner-all" (The share this video overlay dialog).


Version: unspecified
Severity: minor

Details

Reference
bz25495

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport set Reference to bz25495.

mdale wrote:

screen shot of share screen

Hmm I don't know if the user needs to see the full embed code. The idea is just give a single line that can be selected. I see it as width 95%

Attached screen shot of how it looks for me.

Attached:

mwEmbed_share_screen.png (400×454 px, 98 KB)

Created attachment 7750
screenshot of Safari, Mac

Attached:

Screen_shot_2010-10-22_at_15.19.57.png (173×415 px, 23 KB)

mdale wrote:

screenshot windows safari, increased textarea size

I have adjusted the css settings of the text box in r79156 so they should more closely match the text height. At least with windows safari it looks better now

Attached:

share_increased_textarea.png (275×360 px, 38 KB)