Page MenuHomePhabricator

Make limitSelector array configurable from LocalSettings.php
Closed, ResolvedPublic

Description

Author: bdanee88

Description:
You use a predefined array for limit selector in TranslatePage.php line 275 (as of r74652). Please make it configurable from LocalSettings.php, so I dont have to edit original files when I update Translation extension (I use big message groups, like ~6000, so to expose bigger lists to less advanced users, who don't like/know changing URL-addresses by hand, I have to use this solution). It's relatively easy thing to do, I can provide a patch if needed.


Version: unspecified
Severity: enhancement

Details

Reference
bz25498

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport set Reference to bz25498.

Is there reason you need to show all messages at once? I think the only use case for that is for searching with the browsers inbuilt search mechanism, since there is no better alternative for it yet.

If you download the extension directly from SVN you don't need to patch it all the time, but you might get conflicts on updating.

I can apply a patch if you have one.

bdanee88 wrote:

Proposed patch

I've attached the patch. Please tell me if there is any un-MediaWikish coding :)
The reason is that the coherent messages are very scattered in that one large file we working on, and we want to translate these coherent messages together, not linearly, as they are in the file. We cound jump back and forth, but it's just a waste of time :) As you told, the problem occours while updating the extension (and yeah, I use the latest version from SVN), so it would be one less fix I have to apply to Translate extension files. (And easier to change the limits for everybody else :) )

Attached:

I've updated the limits to array( 100, 1000, 5000 ); Is this good enough for you or would you still like to have the patch applied?

Assuming fixed if nobody comments.