Page MenuHomePhabricator

Include xx% into 'mwe-uploaded-status'
Closed, ResolvedPublic

Description

Please include the 'xx% -' from updateProgress: function() into the message:

'mwe-uploaded-status' => '$1% uploaded'

This way the translation are more flexible. Some languages (like German) puts a space between number and %, "$1 %" and at least one language (Turkish) switch it: "%$1"


Version: unspecified
Severity: enhancement

Details

Reference
bz25567

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:21 PM
bzimport set Reference to bz25567.

mdale wrote:

is xx% a special hook for percentage? Can you point me to other msg keys that use this convention?

(In reply to comment #1)

is xx% a special hook for percentage? Can you point me to other msg keys that
use this convention?

Sorry, the syntax "xx%" is misleading. xx is my placeholder for the number only.

The relevant code snippet from mw.UploadInterface.js seems to be:

$j( '#up-pstatus' ).html( parseInt( fraction * 100 ) + '% - ' );

I suggest to move the % to the message 'mwe-uploaded-status' with $1 as variable for the number:

'mwe-uploaded-status' => '$1% uploaded'

mdale wrote:

should be fixed in r25567 Will sync with the extension shortly.