Page MenuHomePhabricator

debug mode should not set public cache headers
Closed, ResolvedPublic

Description

Author: mdale

Description:
The resource loader debug mode should set "must revalidate" NOT something like: Cache-Control: public, max-age=2592000, s-maxage=2592000


Version: 1.17.x
Severity: enhancement

Details

Reference
bz25573

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM
bzimport set Reference to bz25573.

This is a good idea, but it needs to be only enabled on development instances, otherwise this could destroy servers quickly.

Fixed in r75827.

I don't think it's that bad to do this in production because must-revalidate doesn't mean the client will pull the resource again every time: it'll just 304.