Page MenuHomePhabricator

Allow explicit marking of follow-up revisions
Closed, ResolvedPublic

Description

It's very annoying when you forget to mention a follow-up in a commit summary and are not able to get the revisions linked. There should be a manual way to do this; Trevor has some ideas about a UI.


Version: unspecified
Severity: enhancement

Details

Reference
bz25638

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:13 PM
bzimport set Reference to bz25638.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 7755
Mock-up of associate follow-up revisions & sign-off features

This is a mockup of how we should probably layout the associate follow-up revisions and sign-off features.

Attached:

Screen_shot_2010-10-25_at_1.15.26_PM.png (641×1 px, 65 KB)

(In reply to comment #1)

Created attachment 7755 [details]
Mock-up of associate follow-up revisions & sign-off features

This is a mockup of how we should probably layout the associate follow-up
revisions and sign-off features.

Looks nice.
One suggestion though, a way of undo'ing such association would be handy.

Attached:

Screen_shot_2010-10-25_at_1.15.26_PM.png (641×1 px, 65 KB)

Yes, I agree, I will try and work that into another mockup...

Small col on the right hand side with an X in it?

On another note, being able to remove erroneous follow up revisions from bad commit messages, that'd be cool (though, part of the same process)

The commit message can't be changed, but the followup table can be cleaned on the followed up bug :)

Looks good though! :D

Created attachment 7756
Concept for bug 25638

DOM manipulation on http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74525

Attached:

Afbeelding_3.png (426×933 px, 76 KB)

I dislike the term "Dissociation"

Created attachment 7757
Improved version of code review mockup

This version includes the ability to strike sign-offs and remove associations.

Attached:

Screen_shot_2010-10-26_at_10.56.20_AM.png (777×1 px, 86 KB)

  • Bug 26013 has been marked as a duplicate of this bug. ***

Sign-off part (bug 26014) done in r77302.

In r77374, Roan did the bulk of the work for this