Page MenuHomePhabricator

LaTeX tag with empty parameter not highlighted correctly
Closed, ResolvedPublic

Description

Author: quietbritishjim

Description:
This is about the syntaxhighlight tag with lang="latex". As can be seen on the English Wikipedia page for LaTeX, and on the test page linked to in the URL field, the syntax highlighting breaks if you have a tag with an empty parameter. The syntax highlighter thinks that the parameter list hasn't finished, and formats the rest of the text as a parameter list until it next encounters a closing brace.

The example of this that is causing problems is the \LaTeX{} tag, which has empty braces afterwards to prevent LaTeX from swallowing the following space.


Version: unspecified
Severity: minor
URL: http://en.wikipedia.org/wiki/User:Quietbritishjim/LaTeX_bug

Details

Reference
bz25704

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:18 PM
bzimport set Reference to bz25704.
bzimport added a subscriber: Unknown Object (MLST).

Issues in geshi itself must be reported to geshi bugtracker at http://sourceforge.net/tracker/?group_id=114997&atid=670231 thanks.

quietbritishjim wrote:

Sorry about that: I've reported it there, bug rGERRIT30983296c6b8. Feel free to close this bug if you feel that it's most appropriate. If it's left open then I will copy any important updates here from the GeSHi bug.

https://sourceforge.net/tracker/?func=detail&aid=3098329&group_id=114997&atid=670231

The current version (live on wmf site) is 1.0.8.6.

What about "upstream" as keyword?

quietbritishjim wrote:

I've updated the GeSHi bug with that info, thanks. (I assume that the upstream keyword question was aimed at MW Bugzilla regulars.)

quietbritishjim wrote:

From the bug on the GeSHi site: this is now fixed in CVS, and will be in the next stable release. (The current stable version is 1.0.8.9, so presumably the next one will be something like 1.0.8.10.)

Works for me today. We're using GeSHi 1.0.8.11 (with custom hacks) these days.