Page MenuHomePhabricator

Non-existent file namespace pages have a "edit" tab instead of a "create" tab
Closed, InvalidPublic

Description

Author: rehman.wikimedia

Description:


Version: unspecified
Severity: enhancement
URL: http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=393945185#Page_tabs

Details

Reference
bz25722

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:19 PM
bzimport set Reference to bz25722.

rehman.wikimedia wrote:

Sorry it the first time I'm using bugzulla. I have copied the original proposal from Wikipedia (copied from: http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=393945185#Page_tabs):

In the "File:" namespace (using the current new Vector theme), we used to have tabs like (in the respective colours):

  1. For a file that exists: <font color="Blue">'''File'''</font>, <font color="Blue">'''Discussion'''</font>, <font color="Blue">'''Read'''</font>, <font color="Blue">'''Edit'''</font>, <font color="Blue">'''View history'''</font>
  1. For a file that doesn't exist: <font color="Red">'''File'''</font>, <font color="Red">'''Discussion'''</font>, <font color="Blue">'''Create'''</font> <p>These tabs were then changed to:
  1. For a file that exists: <font color="Blue">'''File'''</font>, <font color="Blue">'''Talk'''</font>, <font color="Blue">'''Read'''</font>, <font color="Blue">'''Edit'''</font>, <font color="Blue">'''History'''</font>
  1. For a file that doesn't exist: <font color="Red">'''File'''</font>, <font color="Red">'''Talk'''</font>, <font color="Blue">'''Edit'''</font>

For an editor who frequently works within the File: namespace, the new colouring could be quite misleading and wastes valuable time. In sample 4, I propose renaming the blue "Edit" tab to "Create" as it was before. If this needs too much work across multiple namespaces, then at least recolour it to red.

Kind regards,
Rehman

I'm Changing summary to be more specific (hopefully I understood you right).

Trying a random page... http://en.wikipedia.org/wiki/File:Fdbaskdfsajbjkdsajkdsf.jpg

I see a blue tab labelled "create". Can you give a link to a page where your issue occurs?

Perhaps Rehman, you do not use the interface language "English", but one of the English variants ?

rehman.wikimedia wrote:

@Derk: Yes, I use EN-UK.

@Bawolff: Its probably because of the language variant, as Derk said.

Cant we make it to show a red "Create" on all English variants (or maybe in all languages (translated of course))?

(In reply to comment #5)

@Derk: Yes, I use EN-UK.

@Bawolff: Its probably because of the language variant, as Derk said.

Cant we make it to show a red "Create" on all English variants (or maybe in all
languages (translated of course))?

Still not seeing the error: http://en.wikipedia.org/wiki/File:Fdbaskdfsajbjkdsajkdsf.jpg?uselang=en-gb (I presume you meant en-GB since en-UK is not a lang code). If it is an issue with using an english 'variant' this is something that should probably be taken up with the translate wiki people. (But I don't think it is as I can't reproduce it)

rehman.wikimedia wrote:

(In reply to comment #6)

(In reply to comment #5)

@Derk: Yes, I use EN-UK.

@Bawolff: Its probably because of the language variant, as Derk said.

Cant we make it to show a red "Create" on all English variants (or maybe in all
languages (translated of course))?

Still not seeing the error:
http://en.wikipedia.org/wiki/File:Fdbaskdfsajbjkdsajkdsf.jpg?uselang=en-gb (I
presume you meant en-GB since en-UK is not a lang code). If it is an issue with
using an english 'variant' this is something that should probably be taken up
with the translate wiki people. (But I don't think it is as I can't reproduce
it)

Well, in Special:Preferences in en.wiki, the language variant I am using is no doubt called "en-GB - British English".

And in your sample file link above, I clearly see a blue "Edit" tab... I can provide a screen snapshot if there is a way...

(In reply to comment #7)

Well, in Special:Preferences in en.wiki, the language variant I am using is no
doubt called "en-GB - British English".

And in your sample file link above, I clearly see a blue "Edit" tab... I can
provide a screen snapshot if there is a way...

Are you using any custom css or js that would change the contents of the tab?

rehman.wikimedia wrote:

(In reply to comment #8)

(In reply to comment #7)

Well, in Special:Preferences in en.wiki, the language variant I am using is no
doubt called "en-GB - British English".

And in your sample file link above, I clearly see a blue "Edit" tab... I can
provide a screen snapshot if there is a way...

Are you using any custom css or js that would change the contents of the tab?

I barely got the posting of this bug right, I'm sure I don't use any "custom" css or js (whatever thats supposed to mean) to change anything ;)

I use three different PCs, all three with Firefox 3.6.12, and each with:

  1. XP Professional x32
  2. 7 Home Premium x32
  3. 7 Professional x64

But guess what I discovered, it shows a blue "Create" in Internet Explorer 8.0.6, on my XP (haven't tested the other OSs). Now why is that weird?

I barely got the posting of this bug right, I'm sure I don't use any "custom"
css or js (whatever thats supposed to mean) to change anything ;)

Does the bug still appear logged out (Any custom css/js you may use, for example if you have something checked in the gadgets section of [[special:preferences]] won't apply to you if you're logged out, so checking if it happens when logged out is a good way to narrow it down).

But guess what I discovered, it shows a blue "Create" in Internet Explorer
8.0.6, on my XP (haven't tested the other OSs). Now why is that weird?

That is weird. I'm testing on firefox 3.0.6 (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.11) Gecko/2009061212 Iceweasel/3.0.6 (Debian-3.0.6-1)) in case anyone wonders (not that it should matter).

rehman.wikimedia wrote:

(In reply to comment #10)

Does the bug still appear logged out (Any custom css/js you may use, for
example if you have something checked in the gadgets section of
[[special:preferences]] won't apply to you if you're logged out, so checking if
it happens when logged out is a good way to narrow it down).

Tried when logged out, theres nothing in the "Create"/"Edit" area, as it should be... And the "File" and "Talk" are also red.

Assuming you mean css/js as the gadgets in prefs, I unchecked all the check boxes at preferences/gadgets, and... There is a blue "Create"!

Then I rechecked/unchecked each to find which causes the problem, but it seems re-enabling anything I used "Gadgets" would cause it to change back to a blue "Edit"...

(In reply to comment #11)

boxes at preferences/gadgets, and... There is a blue "Create"!

Then I rechecked/unchecked each to find which causes the problem, but it seems
re-enabling anything I used "Gadgets" would cause it to change back to a blue
"Edit"...

It would be helpfull narrow-down which Gadget on en.wikipedia is causing this.
Do so by unchecking everything, clearing (see [[MediaWiki:Clearyourcache]] to learn how) your cache, and verifying that the link correctly reads "Create" in red.

Then enable one on of the gadgets you used to have and clear cache again and refresh the file-page again, and so forth untill it goes wrong.

rehman.wikimedia wrote:

(In reply to comment #12)

(In reply to comment #11)

boxes at preferences/gadgets, and... There is a blue "Create"!

Then I rechecked/unchecked each to find which causes the problem, but it seems
re-enabling anything I used "Gadgets" would cause it to change back to a blue
"Edit"...

It would be helpfull narrow-down which Gadget on en.wikipedia is causing this.
Do so by unchecking everything, clearing (see [[MediaWiki:Clearyourcache]] to
learn how) your cache, and verifying that the link correctly reads "Create" in
red.

Then enable one on of the gadgets you used to have and clear cache again and
refresh the file-page again, and so forth untill it goes wrong.

Yup, thats what I did, as I said in Comment-11. Enabling anything causes the problem...

(In reply to comment #13)

(In reply to comment #12)

(In reply to comment #11)

boxes at preferences/gadgets, and... There is a blue "Create"!

Then I rechecked/unchecked each to find which causes the problem, but it seems
re-enabling anything I used "Gadgets" would cause it to change back to a blue
"Edit"...

It would be helpfull narrow-down which Gadget on en.wikipedia is causing this.
Do so by unchecking everything, clearing (see [[MediaWiki:Clearyourcache]] to
learn how) your cache, and verifying that the link correctly reads "Create" in
red.

Then enable one on of the gadgets you used to have and clear cache again and
refresh the file-page again, and so forth untill it goes wrong.

Yup, thats what I did, as I said in Comment-11. Enabling anything causes the
problem...

Can you give a specific example of one gadget, where having that, and that alone enabled causes the issue. I just tried a random one, and the behaviour did not occur. I can't imagine you tested all 32 different choices to say that any of them cause the issue.

rehman.wikimedia wrote:

(In reply to comment #14)

Can you give a specific example of one gadget, where having that, and that
alone enabled causes the issue. I just tried a random one, and the behaviour
did not occur. I can't imagine you tested all 32 different choices to say that
any of them cause the issue.

Yes: Twinkle, refTools, Friendly...

Confirmed. issue is caused by friendly (and only friendly, the other gadgets, including refTools and Twinkle do not cause the issue. But Twinkle and friendly seem to have merged, so I don't know what the deal with that is).

Anyways, closing as INVALID (since this is a user script issue, not a mediawiki issue) Please continue this discussion at http://en.wikipedia.org/wiki/Wikipedia_talk:Twinkle/Bugs#TW-B-412_.28new.29

rehman.wikimedia wrote:

(In reply to comment #16)

Confirmed. issue is caused by friendly (and only friendly, the other gadgets,
including refTools and Twinkle do not cause the issue. But Twinkle and friendly
seem to have merged, so I don't know what the deal with that is).

Anyways, closing as INVALID (since this is a user script issue, not a mediawiki
issue) Please continue this discussion at
http://en.wikipedia.org/wiki/Wikipedia_talk:Twinkle/Bugs#TW-B-412_.28new.29

Thank you for your time. Kind regards,
Rehman