Page MenuHomePhabricator

Mail sender ("WikiAdmin") should be configurable
Closed, ResolvedPublic

Description

Mediawiki sends all notification mails about changed pages using the sender name "WikiAdmin".

This is hardcoded in includes/UserMailer.php, line 484:

$adminAddress = new MailAddress( $wgPasswordSender, 'WikiAdmin' );

Now imagine you are working on multiple wikis - all will send you mails with the sender name "WikiAdmin", only the sender mail address differs ($wgPasswordSender).

Please replace the hardcoded "WikiAdmin" with a configurable variable (which would default to WikiAdmin). Something like this:

$adminAddress = new MailAddress( $wgPasswordSender, $wgPasswordSenderName );

Version: 1.16.x
Severity: enhancement

Details

Reference
bz25728

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport added a project: MediaWiki-Email.
bzimport set Reference to bz25728.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 25802 has been marked as a duplicate of this bug. ***

webmaster wrote:

I agree. This variable could alternatively default to $wgSiteName to ease adoption.

I think we should allow $wgPasswordSender to be 'WikiOneo Admin <wiki1@myserver.com>'.

The default $wgPasswordSender IS 'MediaWiki Mail <apache@serverName>' but that's not supported by MailAddress class, producing "WikiAdmin <MediaWiki Mail <apache@serverName>>"