Page MenuHomePhabricator

API: possible issue with revids validation
Closed, ResolvedPublic

Description

Author: matthew.britton

Description:
http://en.wikipedia.org/w/api.php?action=query&revids=123|456

  • works (returns details of revisions)

http://en.wikipedia.org/w/api.php?action=query&revids=-1

  • works (returns "badrevids")

http://en.wikipedia.org/w/api.php?action=query&revids=-1|123

  • the request times out. Any other sequence of IDs that mixes valid and invalid IDs produces the same behavior, e.g.

http://en.wikipedia.org/w/api.php?action=query&revids=10|20|30|40|-50|60

Cannot reproduce locally with trunk, so may already be fixed.


Version: unspecified
Severity: normal
URL: http://en.wikipedia.org/w/api.php?action=query&revids=-1|123

Details

Reference
bz25734

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport set Reference to bz25734.

It is fine on 1.16 and SVN locally for me

matthew.britton wrote:

(In reply to comment #1)

It is fine on 1.16 and SVN locally for me

Probably fixed, then. I'll re-open if it's still a problem when Wikimedia is updated to (an equivalent to) 1.16.

Incidentally, there seems to be no way to report bugs against WMF deployment versions rather than release versions or trunk. Am I supposed to just select "Wikimedia" as the product?

Good idea.

There is now a wikimedia-deployment version of MediaWiki

matthew.britton wrote:

Reopening as 8 months on this still happens (the links in comment #1 that timed out still do).

This is the problem with having what amounts to two separate projects that were forked from 1.15alpha. no way of guaranteeing fixes from one will ever show up in the other.

Someone needs to go back and find where it was fixed in trunk and fix it in wmf deployment.

Still works fine in trunk for me

http://192.168.0.190/w/api.php?action=query&revids=10|20|30|40|-50|60

<?xml version="1.0"?>
<api xmlns="http://www.mediawiki.org/xml/api/">

<query>
  <badrevids>
    <rev revid="20" />
    <rev revid="-50" />
  </badrevids>
  <pages>
    <page pageid="1" ns="0" title="Main Page" />
    <page pageid="9" ns="14" title="Category:En" />
    <page pageid="43" ns="2" title="User:Reedy/LAOLWOALALA" />
  </pages>
</query>

</api>

r89512

Seems the query is doing something retarded, and dies at 4 minutes, which I guess is domas' long query runner