Page MenuHomePhabricator

preg cannot compile patters in CSSMin.php
Closed, ResolvedPublic

Description

Author: p.oranje

Description:
adjusts patterns to use old syntax for naming subpatterns

The preg syntax for patterns allows naming of subpartterns.
When using preg with version < 5.2.2 the syntax used by CSSMin (?<name>) isn't supported. The older syntax (?P<name>) can be used on all versions though; so please use that (patch attached).

See also http://php.net/manual/en/function.preg-match.php.


Version: 1.17.x
Severity: normal
OS: Linux

Attached:

Details

Reference
bz25735

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport set Reference to bz25735.

Patch applied in r75792, thanks.

The attached patch was reversed and left the old lines commented out rather than removing them. Use the "svn diff" command to produce a diff from an SVN checkout.