Page MenuHomePhabricator

Comma should be internationalized in AbuseFilter user interface
Closed, DeclinedPublic

Description

The comma separating the phrases under "Consequences" column in the AbuseFilter home is hard-coded and not internationalized. To be compliant with MediaWiki standards, it should be i18ned.


Version: unspecified
Severity: enhancement

Details

Reference
bz25749

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:21 PM
bzimport set Reference to bz25749.

Not sure which version has been deployed at Wikimedia at the moment, but the below piece of code that is currently in trunk suggests this is being done (r63691 / March 13, 2010):
case 'af_actions':
$actions = explode( ',', $value );
$displayActions = array();
foreach ( $actions as $action ) {

		$displayActions[] = AbuseFilter::getActionDisplay( $action );

}
return htmlspecialchars( $wgLang->commaList( $displayActions ) );

Wikimedia is running some pretty old code...

Closing as works for me.