Page MenuHomePhabricator

Diff page loading seems to stall for logged-in users
Closed, ResolvedPublic

Description

The fix for bug 25289 (diff pages load slowly) seems to work well in Firefox, but seems to stall every other page load in Chrome.


Version: unspecified
Severity: minor

Details

Reference
bz25757

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM
bzimport set Reference to bz25757.

(In reply to comment #0)

The fix for bug 25289 (diff pages load slowly) seems to work well in Firefox,
but seems to stall every other page load in Chrome.

Which version? Do you have a good example diff url? I'm not getting this on my testwiki.

Priyanka and I did some investigation on this, and it seems to be related to logged-in status rather than browser. Changing summary to reflect.

Here's a repro:

Visit this page:
http://prototype.wikimedia.org/flaggedrevs-w/index.php?title=Pakistan&action=historysubmit&diff=12188&oldid=12186

...then click on "Previous edit"

When you're not logged-in, it loads right away. When you are logged in, there's a long delay.

Hm.. since when is the article below the diff loaded via ajax ? Seems a unnececary extra call ?

Krinkle: see bug 25289. There are cases where the diff page takes a very long time to load due to the display of the later revision in the diff. The old workaround (the diffonly option) is something that wasn't viewed as appropriate for use with Pending Changes (see bug 24315), and this solution let's us actually see the later revision eventually without stalling the diff display in the process.

pdhanda wrote:

After a conversation with Roan, seems that this was a problem we were seeing in prototype because we we not using our custom session storage that uses memcached.

Setting $wgSessionsInMemcached = true; fixed this in prototype.

Also r78212 should make the diffs load faster.

pdhanda wrote:

Merged r78212 and r78213 into branches/priyanka-wmf-fixes.