Page MenuHomePhabricator

IE8 upload fails silently on Enter key from wpDestFile
Closed, DeclinedPublic

Description

Author: wilson.jim.r

Description:
In IE, on Special:Upload, hitting the Enter key when wpDestFile is focused causes the upload to fail silently, bringing the user back to the Special:Upload screen, with little indication as to what happened.

I noticed this behavior on MW 1.16.0, and confirmed that it still happens on MediaWiki.org, which is currently running 1.16wmf4 (r76474).

This problem does not occur in Firefox or Safari.

I have only tested IE 8 - I do not know what other IE versions are affected.


Version: unspecified
Severity: minor
URL: http://www.mediawiki.org/wiki/Special:Upload

Details

Reference
bz25885

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport set Reference to bz25885.
bzimport added a subscriber: Unknown Object (MLST).

neilk wrote:

Could verify this if user deleted filename, which seems low priority, but need to double check if this occurs if the user *doesn't* delete filename, which is higher priority

neilk wrote:

I was wrong, it's not about blanking the field. It's about a form submitted (accidentally or by design) by pressing enter.

The reason this happens is that SpecialUpload.php will only process an upload if the parameter 'wpUpload' is present; in other words, if the user clicked the button. IE doesn't send the button's name or value if you don't click it.

Looks like just a bug, although it seems deliberate so I want to be careful. So far it's hard to determine exactly when 'mUploadClicked' became mandatory.

Thehelpfulonewiki wrote:

Reassigning to wikibugs-l per bug 37789

matmarex lowered the priority of this task from Medium to Lowest.Aug 30 2015, 11:38 PM
matmarex set Security to None.
matmarex removed a subscriber: wikibugs-l-list.
Aklapper changed the task status from Open to Stalled.Feb 5 2022, 8:05 PM
Aklapper added a project: TestMe.

Does this still happen in IE9 or later? IE8 isn't supported anymore - https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix

Aklapper renamed this task from IE upload fails silently on Enter key from wpDestFile to IE8 upload fails silently on Enter key from wpDestFile.Feb 5 2022, 8:05 PM
Aklapper removed a project: TestMe.

We don't support IE8 anymore