Page MenuHomePhabricator

NullRevision to a page should not produce pending changes for pages transcluding it
Closed, ResolvedPublic

Description

When block or unblock a page, a NullRevision is created (Revision::newNullRevision) and all pages which using this page as template have a pending change ("There are template/file changes awaiting review"). It is possible to ignore these changes for FlaggedRevs?

Thanks.


Version: unspecified
Severity: enhancement

Details

Reference
bz25919

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport set Reference to bz25919.

Addition: When a page from an unreviewable namespace is used as a template in a reviewable namespace and get a block, all the user of the template have to reviewed manual.

I don't think there is any effective way to check for this at all (skipping down the top X edits because they are null). Even with some rev_type flag or something, it would not be efficient like checking page_latest, so you would need a page_latest_unique or something.

This looks like a wontfix unfortunately.

Alternately, findPendingTemplateChanges() could fetch and compare the rev_text_id field for $revIdDraft and $revIdStable...at a performance penalty.

(In reply to comment #3)

Alternately, findPendingTemplateChanges() could fetch and compare the
rev_text_id field for $revIdDraft and $revIdStable...at a performance penalty.

Done in r77211. Shouldn't have little db effect.

(In reply to comment #4)

(In reply to comment #3)

Alternately, findPendingTemplateChanges() could fetch and compare the
rev_text_id field for $revIdDraft and $revIdStable...at a performance penalty.

Done in r77211. Shouldn't have little db effect.

*Should have* I mean.