Page MenuHomePhabricator

AbuseFilter API: output problems with aflprop=details
Closed, DeclinedPublic

Description

Author: matthew.britton

Description:
When requesting details of an abuse log item (with an aflprop value containing "details"), often the request returns after a few seconds with just the following (with xml format selected):

<?xml version="1.0"?>

When it does return it is very slow even for the default item limit (10) and can often return as above even with a limit of 1.

Currently the maximum limit is 500. This is no problem at all when fetching only the basic log information (no "details" in aflprop). It is evidently a problem when details are requested.

Two things should be done to address this:

  • Add an "aflid" parameter, that overrides other filtering parameters and retrieves the single abuse log entry with that ID. Make aflprop=details valid only when this parameter is specified. This should fix the performance issue, whilst still allowing details to be fetched, and as a bonus allow easier retrieval of a single abuse log entry.
  • Investigate whether the blank output as above is sometimes due to an error condition, rather than a timeout of some sort. (The fact that the query in the URL field sometimes works and sometimes doesn't, presumably dependent on whatever the last abuse log entry was, suggests this).

Version: unspecified
Severity: normal
URL: http://en.wikipedia.org/w/api.php?action=query&list=abuselog&aflprop=details&afllimit=1

Details

Reference
bz25928

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:20 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz25928.
bzimport added a subscriber: Unknown Object (MLST).

I can't reproduce any of these problems. I guess the new logging system (https://gerrit.wikimedia.org/r/42501) I've introduced in late February is the cause for this (at least it was one of its purposes to accelerate log detail access).