Page MenuHomePhabricator

Chaos in the interface of FlaggedRevs
Closed, ResolvedPublic

Description

Author: danny.leinad

Description:
Screen of 3 blue boxes

To reproduce:

  1. Go to [[Special:Preferences]], "Edit review" tab and set options "Use detailed boxes to show review status of pages" and "Show the pending changes diff when viewing the latest pending revision".
  2. Open page with pending changes - look at the top of the page, there are 3 blue boxes and 2 of them have very smiliar text (added attachment with screen).

Version: unspecified
Severity: enhancement

Attached:

FlaggedRevs_interface_chaos.png (800×1 px, 209 KB)

Details

Reference
bz25975

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:24 PM
bzimport set Reference to bz25975.

Priyanka, can you look into this one?

I'm looking at this now. It's pretty easy to break the UI trying to fix this without a lot familiarity.

pdhanda wrote:

Aaron, assigning this to you then.

Since r76958, the new notice is now unused for the detailed bar UI. This puts the clutter back to the level it was at before for the detailed bar UI.

I've got some things to ask Brandon about which I need to elaborate on. Assigning to myself until I actually put something coherent together for Brandon to look at.

Rob, what was the outcome of the conversation with Brandon?

I'm very tempted to just remove this preference.

The diff now goes in the already existing notice bar in r82541.