Page MenuHomePhabricator

When $wgSpamRegex is triggered be sure to return to editing and not throw the user's work away
Closed, DeclinedPublic

Description

If $wgSpamRegex is triggered, be sure to return the editing contents
to the user in a box that he can keep on editing.
Don't just expect him to know or be told to hit the BACK key, or
expect BACK will always work in such situations. (Otherwise even when
just previewing an edit, one could just tell the user "This is a
preview. To continue editing just hit BACK.")

Anyway, we are not finished editing. We need to alter what was seen as
a spam word. But instead our hard work is thrown away and we get a
spam warning with no box with our content to continue our editing.
Also the user thinks "You didn't warn me when I hit Preview. Now you
spitefully threw away my work when I hit Save, with no edit box to
continue my hard work."


Version: 1.17.x
Severity: major

Details

Reference
bz25985
TitleReferenceAuthorSource BranchDest Branch
Update buster-based images to composer 2.1.8repos/releng/dev-images!7jforrestercomposer-2main
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:11 PM
bzimport set Reference to bz25985.
bzimport added a subscriber: Unknown Object (MLST).

The current solution WORKSFORME. When the spam detector is triggered the editor gets:

Spam protection filter

The text you wanted to save was blocked by the spam filter. This is probably caused by a link to a blacklisted external site.

The following text is what triggered our spam filter: http://youtu.be

Differences

(...)

Your text

(...)

You can click back or you can copy your text and do whatever with it. Good enough.