Page MenuHomePhabricator

Using PCRE Nested named refs do not work
Closed, ResolvedPublic

Description

Creating as tracking bug against r76938 reversion of r76928


Version: 1.17.x
Severity: normal
See Also:
http://bugs.exim.org/show_bug.cgi?id=1035

Details

Reference
bz25986

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:11 PM
bzimport set Reference to bz25986.
bzimport added a subscriber: Unknown Object (MLST).

Cheers guys for posting the bug upstream

Since that is fixed upstream an Aaron did a workaround with r77067, maybe we can fix this bug report ?

Tagging bugreport for platform eng since everyone there is part of that team :-)

If by "fixing the bug" you mean reverting the workaround so that MW will segfault if used with PCRE 8.0.1, then we might need to wait a bit longer, since there are still a lot of Linux servers using a distro from 2010. Once we do switch to the new regex, we will have to add an installer environment check for the old library version.

No no! I do not want us to break on old PHP setups.

I am just saying our bug report can probably be closed since:

  • our code no more rely on nested named reference
  • upstream has fixed it.

Of course, if we ever want to use nested named reference, we will hit this bug again.

So maybe we are going to keep this bug around till everyone has the fix :-D

it's been 2 years... 5 years since fixed upstream. I'm closing this, I don't see how keeping this open helps us, considering the activity the ticket has seen over the past 5 years....

TheDJ claimed this task.

Seems fine to close this bug. From the bug report it has been introduced in PCRE release 8.01 and fixed end of 2010 with release of 8.11 (10-Dec-2010):

http://www.pcre.org/original/changelog.txt

  1. Change 18 of release 8.01 broke the use of named subpatterns for recursive back references. Groups containing recursive back references were forced to be atomic by that change, but in the case of named groups, the amount of memory required was incorrectly computed, leading to "Failed: internal error: code overflow". This has been fixed.

Wikimedia PHP on Precise links against PCRE 8.12 from 2011-01-15.