| • bzimport | |
| Nov 19 2010, 11:41 PM |
| F7047: diff-confirmedittext.diff | |
| Nov 21 2014, 11:13 PM |
| F7048: Title.patch | |
| Nov 21 2014, 11:13 PM |
Author: david
Description:
With
$wgEmailConfirmToEdit = true;
the RSS and Atom Recent Changes feeds don't have diffs. (Same with individual pages' history.) I checked that setting $wgEmailConfirmToEditor to false restores the diffs. I attached a patch that restoers the diffs, but I'm not sure it's the right thing.
Version: 1.16.x
Severity: minor
david wrote:
Patch to ignore 'confirmedittext' as a reason not to show a diff.
Attached:
Created attachment 7841
Patch to change Title::getUserPermissionsErrors() to make correct checks for read permission
The problem is bigger that this. Title::getUserPermissionsErrors() is not supposed to be used to check for read permissions; but Title::userCanRead() can only check permissions for $wgUser.
I attached a patch to make Title::getUserPermissionsErrors() check correctly for read permissions; dunno if Domas will like it since it's ~1.4 times slower than the old method (on my local machine).
Attached: