Page MenuHomePhabricator

ArticleDelete hook called with $error as value, should be reference
Closed, ResolvedPublic

Description

Author: Nx.devnull

Description:
ApiDelete.php calls the ArticleDelete hook with the $error parameter as a value. This breaks pywikipediabot's delete.py when (for example) AbuseFilter is installed, since $error should be a reference.


Version: 1.17.x
Severity: normal

Details

Reference
bz26075

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport set Reference to bz26075.

Nx.devnull wrote:

Why hasn't this been backported to MW 1.16?

(In reply to comment #2)

Why hasn't this been backported to MW 1.16?

The simple answer to that, is there was no explicit request to.