Page MenuHomePhabricator

Enable flood flag on zhwiki
Closed, ResolvedPublic

Description

Per community consensus, please enable flood flag on zhwiki.

B'crats should be able to add or remove this flag for all users, and admins should be able to add this flag to themselves.

Local discussion: http://zh.wikipedia.org/wiki/Wikipedia:%E4%BA%92%E5%8A%A9%E5%AE%A2%E6%A0%88/%E6%96%B9%E9%92%88#Flood_flag
Local policy: http://zh.wikipedia.org/wiki/Wikipedia:%E6%9C%BA%E5%99%A8%E4%BA%BA%E7%94%A8%E6%88%B7

Regards.


Version: unspecified
Severity: major
URL: http://zh.wikipedia.org/wiki/Wikipedia:%E4%BA%92%E5%8A%A9%E5%AE%A2%E6%A0%88/%E6%96%B9%E9%92%88#Flood_flag

Details

Reference
bz26117

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport set Reference to bz26117.
bzimport added a subscriber: Unknown Object (MLST).

Waiting for enable...

flood flag should include bot permissions. Am I right?

(In reply to comment #1)

Waiting for enable...

flood flag should include bot permissions. Am I right?

Flood flag typically just means your edits get marked as 'bot' in the RC. The bot usergroup also includes some other things like not being affected by rate limits, which typically flood people do not have. See https://secure.wikimedia.org/wikinews/en/wiki/Special:ListGroupRights for how its set up at Wikinews, which i believe is the default set up (except that on wikinews the 'flood' flag is called pseudo-bot ).

jeluf wrote:

Your change has been completed.
Please reopen this ticket if anything went wrong.

The following configuration settings have been changed:

Index: InitialiseSettings.php

  • InitialiseSettings.php (revision 1356)

+++ InitialiseSettings.php (working copy)
@@ -5814,6 +5814,7 @@

'rollbacker' 	=> array( 'rollback' => true ),
'patroller'		=> array( 'patrol' => true, 'autopatrol' => true ),
'autoreviewer'  => array( 'autopatrol' => true ),

+ 'flood' => array( 'bot' => true ),

),

'zhwikinews' => array(

@@ -6154,7 +6155,7 @@

    'sysop' => array( 'autoeditor' ),
),
'+zhwiki' => array(
  • 'bureaucrat' => array( 'sysop', 'bureaucrat', 'bot' ),

+ 'bureaucrat' => array( 'sysop', 'bureaucrat', 'bot', 'flood' ),

	'sysop' => array( 'patroller', 'rollbacker', 'autoreviewer', 'confirmed' ),
),
'+zh_yuewiki' => array(

@@ -6430,7 +6431,7 @@

    'bureaucrat' => array( 'sysop','bureaucrat','bot','autopatrolled','import' ),
),
'+zhwiki' => array(
  • 'bureaucrat' => array( 'bot' ),

+ 'bureaucrat' => array( 'bot', 'flood' ),

	'sysop' => array( 'patroller', 'rollbacker', 'ipblock-exempt', 'autoreviewer', 'confirmed' ),
),
'+zh_yuewiki' => array(

@@ -7821,6 +7822,7 @@

	'strategywiki' => array(
		'sysop' => array( 'flood' ),
	),

+ 'zhwiki' => array( 'flood' ),
),
'wgGroupsRemoveFromSelf' => array(

	'metawiki' => array( 'sysop' => array( 'flood' )),

You can find the entire config file at
http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php

Now seems once an admin grants himself flood flag, he can't remove it. This is not the desired behavior :(

A * indicates that you cannot remove the group once you have added it, or vice versa.

Groups you can change
bot user*

jeluf wrote:

Your change has been completed.
Please reopen this ticket if anything went wrong.

The following configuration settings have been changed:

Index: InitialiseSettings.php

  • InitialiseSettings.php (revision 1362)

+++ InitialiseSettings.php (working copy)
@@ -7837,6 +7837,7 @@

	'simplewikiquote' => array( 'sysop' => array( 'flood' )),
	'plwiki' => array( 'flood' => array( 'flood' )), // https://bugzilla.wikimedia.org/show_bug.cgi?id=20155 , bug 21238
	'strategywiki' => array( 'sysop' => array( 'flood' ) ),

+ 'zhwiki' => array( 'flood' ),
),
'wgEnableAPI' => array(

'default' => true,

You can find the entire config file at
http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php

Apologize for any inconvenience but this still not right... Now sysop can't even add himself to the flood group :(

To make it clear, the desired behavior should be:

  • Sysops can add and remove themselves;
  • B'crats can add and remove anyone.

Regards.

I don't think now sysop cannot grant permission to themselves but a serious plobrem is happen: ALL USER NOW HAVE PERMISSION TO GRANT THEMSELVES FLOOD PERMISSION.

I am just autoconfirmed, patrol and rollback (user is also, of course), but in Special:Userrights, I can grant myself flood permissions. It seems some things goes wrong.

Please fix this serious plobrem as soon as possible. Change to major since this plobrem.

Fixed.

Index: wmf-config/InitialiseSettings.php

  • wmf-config/InitialiseSettings.php (revision 1370)

+++ wmf-config/InitialiseSettings.php (working copy)
@@ -7826,7 +7826,7 @@

'strategywiki' => array(
        'sysop' => array( 'flood' ),
),
  • 'zhwiki' => array( 'flood' ),

+ 'zhwiki' => array( 'sysop' => array( 'flood' ) ),
),
'wgGroupsRemoveFromSelf' => array(

'metawiki' => array( 'sysop' => array( 'flood' )),

@@ -7838,7 +7838,7 @@

'simplewikiquote' => array( 'sysop' => array( 'flood' )),
'plwiki' => array( 'flood' => array( 'flood' )), // https://bugzilla.wikimedia.org/show_bug.cgi?id=20155 , bug 21238
'strategywiki' => array( 'sysop' => array( 'flood' ) ),
  • 'zhwiki' => array( 'flood' ),

+ 'zhwiki' => array( 'sysop' => array( 'flood' ) ),
),
'wgEnableAPI' => array(

'default' => true,

Well, still not right......

I granted myself flood flag, and now there's no way removing it...

(In reply to comment #9)

Well, still not right......

I granted myself flood flag, and now there's no way removing it...

Since you were the only person that did so, I removed it for you in the database.

Things are messed up now... Roan you know what the problem is :)

(In reply to comment #9)

I granted myself flood flag, and now there's no way removing it...

May be related to bug 24826?

Now the situation is:


Just now I opened Special:UserRights/Jimmy_xu_wrk, and the "[ ] bot user" option is there, without a "*". I ticked that box, submit, it works, I got flood.

Then the option became "[v] bot user*", note that the "*" is there. I removed the tick, submit, it works again, I got no flood.

Then there is the problem: the "[ ] bot user" is greyed out and I can no longer tick it.

Then, I used Chromium's inspector to remove "disabled=\"disabled\"" from that grey <input name="wpGroup-flood" ... >, ticked that box, submit. Suddenly I got flood again, and a "[v] bot user*".


IMHO the permission settings are correct, just aren't displayed correctly.

From my reading of the config file, its currently configured so that both sysops, and b'crats can remove the flood flag from any user, but only b'crats can add flood to any user. I don't think sysops are supposed to have the right to remove this group from anyone other than themselves.

(In reply to comment #14)

From my reading of the config file, its currently configured so that both
sysops, and b'crats can remove the flood flag from any user, but only b'crats
can add flood to any user. I don't think sysops are supposed to have the right
to remove this group from anyone other than themselves.

I allowed sysops to remove from all in an attempt to mitigate the remove-from-self feature being broken.

(In reply to comment #12)

(In reply to comment #9)

I granted myself flood flag, and now there's no way removing it...

May be related to bug 24826?

Very likely to be the same bug, yes. Closing this one as FIXED because the config changes were done.

public.wiki wrote:

This application is arbitrary as it is not a formal consensus on zh-Wikipedia!

(In reply to comment #17)

This application is arbitrary as it is not a formal consensus on zh-Wikipedia!

This is not what "INVALID" means. If there's no consensus, please open a new bug to remove the group with a link to a discussion which shows that there's no consensus for it. In the linked discussion you seem the only opposer.