Author: danny.leinad
Description:
After r75332 (see bug25289) diff mode is broken - categories and iw links are not visible.
Version: unspecified
Severity: major
Description
Description
Details
Details
- Reference
- bz26163
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • RobLa-WMF | T28334 Bugfixes for 2010-12-22 deploy of FlaggedRevs (tracking) | |||
| Resolved | None | T28163 Categories and IW links not visible on FlaggedRevs diff pages |
Event Timeline
Comment Actions
danny.leinad wrote:
I've changed severity to major level - this is uncomfortable situation when editors can't distinguish when missing cat and iw and when it is caused by a bug.
Please fix ASAP.
Comment Actions
pdhanda wrote:
Should be fixed in r77515 (trunk). I did some testing on prototype.
Assigning to robla to figure out next steps.
Comment Actions
(In reply to comment #2)
Should be fixed in r77515 (trunk). I did some testing on prototype.
Assigning to robla to figure out next steps.
Re-opening per CR comments, unfortunately :/
Comment Actions
Correction: fixed in r77516
Leinad, can you test that this is indeed fixed to your satisfaction? We've deployed the fix to some of the prototype wikis, including:
http://prototype.wikimedia.org/pl.wikipedia.org/
Assuming Leinad feels like this is ready to go, I'd like to get Aaron and Chad's thoughts on deploying this fix as a one-off. Barring a one-off deployment, this will almost certainly be in the batch of fixes we're slating for later this month.
Comment Actions
Sorry Aaron, I hadn't read your comment on r77516 before replying here. Looks like we shouldn't rush out a bad fix for this.
Comment Actions
pdhanda wrote:
So clearly my fix is not going to work for this. I misunderstood how the parser gets those links out. For now, I think I'm going to change this to using an api call to get categories and langlinks.
Taking this one back while I work on that.
Comment Actions
pdhanda wrote:
Robla, can you verify the styles look like what you had in mind?
Commits in trunk: r77896, r77897, r77930, r78346. Commits in branches/priyanka-wmf-fixes: r77943, r77944, r78348
Comment Actions
danny.leinad wrote:
I see that bug is "resolved", so could you sync to Wikimedia projects?
Comment Actions
This has been deployed now. Note, there's one workaround that was discussed elsewhere, but easy to miss if you were just following this bug. Interwiki links are shown on the bottom of the page rather than in the sidebar. See http://www.mediawiki.org/wiki/Special:Code/MediaWiki/77516 for the discussion and justification for this.