Page MenuHomePhabricator

mwsuggest invalid syntax
Closed, InvalidPublic

Description

if( r == null ) {

		return; // not our event

}

Shouldn't it be returning true/false?


Version: unspecified
Severity: trivial

Details

Reference
bz26174

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:25 PM
bzimport set Reference to bz26174.

not really. Javascript is not that ordered. It shouldn't return false (which would end bubbling), but other than that, I don't think there are any return value restrictions on eventhandlers.

Also note that not returning a value in Javascript implicitly means returning null.

"Return value of type prevents selection is required" is the error the IDE is whinging about. I've no idea what it means

Will revert back when I get some clarification