Page MenuHomePhabricator

Filtering by author, then by path, gets an overly long query string, with duplicate parameters
Closed, ResolvedPublic

Description

Special:Code/MediaWiki/author/reedy

Filter by "/trunk/extensions/CodeReview/"

And we end up at
index.php?path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki&limit=50&title=Special:Code/MediaWiki/author/reedy

It works, but we've got 2 titles

Clicking again on the go button to filter by path, we then get

index.php?path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki&limit=50&path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki/author/reedy


Version: unspecified
Severity: minor

Details

Reference
bz26195

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:12 PM
bzimport set Reference to bz26195.
bzimport added a subscriber: Unknown Object (MLST).

Filtering by path twice does the same..

index.php?path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki/path&limit=50&title=Special:Code/MediaWiki

index.php?path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki/path&limit=50&path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki

For the one above, clicking back onto the filtered author again, goes back to the first..

I should say that this is on trunk, 1.16wmf4 seems fine...

Perhaps trunk (coincidently?) fixed bug 26141 by dirty appending the new variable to the current address.
That would explain the difference why bug 26141 is fixed in trunk but also the long urls

Can't find an svn revision to proof this though.

(In reply to comment #3)

Perhaps trunk (coincidently?) fixed bug 26141 by dirty appending the new
variable to the current address.

You should build the query string in an array and use wfArrayToCGI().

(In reply to comment #4)

(In reply to comment #3)

Perhaps trunk (coincidently?) fixed bug 26141 by dirty appending the new
variable to the current address.

You should build the query string in an array and use wfArrayToCGI().

That sounds like one way of saying we need to revamp the whole way that CR does parameters.

Rather than:
Special:Code/repo/author/authorname
Special:Code/repo/path/path/to/somewhere

etc, do them all as &parameter=value

(In reply to comment #5)

(In reply to comment #4)

(In reply to comment #3)

Perhaps trunk (coincidently?) fixed bug 26141 by dirty appending the new
variable to the current address.

You should build the query string in an array and use wfArrayToCGI().

That sounds like one way of saying we need to revamp the whole way that CR does
parameters.

Rather than:
Special:Code/repo/author/authorname
Special:Code/repo/path/path/to/somewhere

etc, do them all as &parameter=value

The form should submit them that way, but I like being able to do /repo/author/catrope .

Fixed in backlog, ie r88550 I guess...