ContactPage Extension: Bugfix Remember Checkbox Value
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Dec 2 2010, 12:36 PM

Description

Author: cmitasch

Description:
Hello,

I just tried out the ContactPage Extension and fixed one bug:

SpecialContact.php:
235c241

< Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', 'wpCCMe', $wgUser->getBoolOption( 'ccmeonemails' ) ) .

					Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', 'wpCCMe', $this->cc_me ) .

The problem is that if the form is filled out and a value es empty, the checkbox value is not remembered when the form is showed a second time.

The Value "ccmeonemails" does only exist in this part of the code and nowhere else, so the value can never have an value.

Please push the patch forward!

Thank you,
Christoph

Version: unspecified
Severity: enhancement

Details

Reference: bz26201

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:13 PM

• bzimport added a project: MediaWiki-extensions-ContactPage.

• bzimport set Reference to bz26201.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Dec 2 2010, 12:36 PM

(In reply to comment #0)

SpecialContact.php:
235c241
< Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe',

'wpCCMe', $wgUser->getBoolOption( 'ccmeonemails' ) ) .
					Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', 'wpCCMe', $this->cc_me ) .

This patch was trivial and very easy to apply by hand, but in the future please attach your patches as files and use unified diff format ("diff -u" or "svn diff").

Please push the patch forward!

Thanks for the patch! Applied in r77577.

ContactPage Extension: Bugfix Remember Checkbox ValueClosed, ResolvedPublicActions

Description

< Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', 'wpCCMe', $wgUser->getBoolOption( 'ccmeonemails' ) ) .

Details

Event Timeline

'wpCCMe', $wgUser->getBoolOption( 'ccmeonemails' ) ) .

ContactPage Extension: Bugfix Remember Checkbox Value
Closed, ResolvedPublic
Actions