Page MenuHomePhabricator

Wrong number of total revisions displayed at top of the list view
Closed, ResolvedPublic

Description

On my test wiki, MW repo, one revision tagged as "lol", and only one returned, but it says "Total number of results: 77,378"


Version: unspecified
Severity: minor

Details

Reference
bz26235
ReferenceSource BranchDest BranchAuthorTitle
repos/releng/cli!21portValidationmainaddshoredev: Check that the PORT can be listened on
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:15 PM
bzimport set Reference to bz26235.
bzimport added a subscriber: Unknown Object (MLST).

Above is Wrong number of total revisions when filtered by tag

Seemingly occurs in more states...

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/status/fixme?author=platonides

Looks like some of the list view classes need to override either getSpecializedWhereClause, or the entire getRevCount method...

... or better yet, replace getRevCount() by calling into the pager and turning its query into a count(*) without the offset/limit. That would avoid having to duplicate the query code that's already in the SvnRevTablePager subclasses.

Might see if I can get chance to poke at this sometime this week...

Created attachment 8046
Patch for quick sanity check

Attached: