It'd be helpful if we could filter comments, especially by author. The other day, I was looking for a comment that Tim had made a while back: I ended up having to dig through the list of recent comments with control-f.
Version: unspecified
Severity: enhancement
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | Feature | None | T28337 Enable bottom limit form on CodeRevisionListView when CR queryparams suck no more | ||
| Resolved | None | T28240 CodeReview's (partial absence of) query params suck (tracking) | |||
| Resolved | None | T28754 Support for path and author on CR-specific pages (comments, statuschanges, tags etc.) | |||
| Resolved | None | T28567 Allow showing comments by a given user, add "my comments" link to subtitle | |||
| Resolved | None | T28236 Add filters for CodeReview comments |
Will need an index against code_comment indexing the author
cc_repo_id, cc_author, cc_timestamp - we will want to filter by repo, and then the author... And then order by timestamp.
Added index, groundwork and filtering code.
Just needs either a new form, or something adding to the comments list view to select who/what to filter by
So, this is mostly done
Or we put some sort of link on the comments page, rather than just linking to the userpage..
Any suggestions how to finish this off nicely in the GUI?
Ie how to put the comments link for a specific user, to make it slightly user friendly...
And this is actually a dupe (or more, a subset) of bug 26754, and bug 26567 to some extent...
Closing as such for EASE