Page MenuHomePhabricator

WikiEditor toc module: textarea not hidden on ProofreadPage pages
Closed, ResolvedPublic

Description

Picture showing the bug

When the toc module from the WikiEditor extension is active, the textarea (wpTextArea1) on ProofreadPage pages is not properly hidden, leading to double text display (see the URL and the attached screenshot). When deactivating the toc module in the preferences, the textarea is properly hidden, and everything looks fine.

Loading and saving of pages work fine, it just looks quite strange.
This is on current SVN trunk and happens with IceWeasel 3.5.15 and Chromium 6.0.472.63~r59945-2.


Version: unspecified
Severity: normal
URL: http://spiele.j-crew.de/w/index.php?title=Scan:9s_mor.pdf/1&action=edit

Attached:

wikieditor-toc-bug-proofreadpage.png (600×1 px, 107 KB)

Details

Reference
bz26303

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:20 PM
bzimport added a project: ProofreadPage.
bzimport set Reference to bz26303.

On r80818, together with up-to-date ProofreadPage (r81155) and WikiEditor (r 81165) extension, the page looks exactly the same as in the screenshot.

I tried to test with newer phase3, but when using r81272, the WikiEditor toolbar doesn't show up at all! I haven't had time to track this down yet.

So yes, as far as I can tell the problem is still there.

Appears to be proofreadPage's fault when it removes the wpTextbox1 and then replaces it with its own version, that doesn't have the relevant styes (see proofreadpage.js)

Changing component to proofreadpage

FWIW, this still happens in current MediaWiki (r98745), with up-to-date ProofreadPage (r98583) and WikiEditor (r98463).

sumanah wrote:

Is this still happening, with the version of the code now on Wikimedia sites?

beau wrote:

Yes, it still reproducible. As far as I know this function of Wikieditor is experimental and is not available on Wikimedia sites yet.