Page MenuHomePhabricator

deleting translation from Message.php does not update to fallback
Closed, ResolvedPublic

Description

r78013 removes key 'december' from MessagesDe_at.php, but on de.wp the message [[de:MediaWiki:December/de-at]] is not updated to the fallback.

The sync has work for other messages like [[de:MediaWiki:Htmlform-submit]] (r78138)

It is possible to update the message to the fallback, when it is removed from Message.php? Thanks


Version: unspecified
Severity: enhancement

Details

Reference
bz26325

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM
bzimport set Reference to bz26325.

For information: With r79023 the key was readded to MessagesDe_at.php.

You have to unset a message key, when the key is in the $compare_messages (because it is in the default Message*.php or the cache from previous updates), but not in $base_messages (because the key was removed from svn). With an unset of the message key the fallback of MediaWiki should work.

(In reply to comment #2)

You have to unset a message key, when the key is in the $compare_messages
(because it is in the default Message*.php or the cache from previous updates),
but not in $base_messages (because the key was removed from svn). With an unset
of the message key the fallback of MediaWiki should work.

Sounds like this shouldn't be too hard, taking this bug.

tom.maaswinkel wrote:

this is actually a feature, not a bug. It is to prevent a message that's deleted in a newer version of MediaWiki to also be removed in older version that still use that message!

(In reply to comment #4)

this is actually a feature, not a bug. It is to prevent a message that's
deleted in a newer version of MediaWiki to also be removed in older version
that still use that message!

Right...

There's a difference though between the message being deleted from trunk completely and only being deleted from one language (in the latter case, that's meant to trigger the fallback). So if a message is removed from the language we're processing but still present in English, I think we should remove it from LU too, and keep it otherwise. Sound about right?

tom.maaswinkel wrote:

That sounds like the right solution

Needs testing, if still a issue. Some changes to LocalisationUpdate was made in past month/year.

Paladox subscribed.

Can this be closed since mediawiki now uses .json format.

Umherirrender claimed this task.