Page MenuHomePhabricator

Audio player overflowing
Closed, ResolvedPublic

Description

Hello,
Our audio player is hiding some informations for a few weeks, for example the IPA into http://fr.wiktionary.org/wiki/armure#Prononciation.


Version: unspecified
Severity: enhancement
URL: http://fr.wiktionary.org/wiki/Wiktionnaire:Wikid%C3%A9mie/d%C3%A9cembre_2010#lecteur_audio

Details

Reference
bz26346

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:23 PM
bzimport set Reference to bz26346.

Apparently, it comes from the mwEmbed JS.

As you didn't answer I removed mwEmbed from Common.js (to put it into [[MediaWiki:Gadget-mwEmbed.js]]).

mdale wrote:

compared player layouts of mwEmbed

Attached:

compared_player_layouts.png (460×673 px, 41 KB)

mdale wrote:

That's strange I did not get this bug in my email until now :( The player is set to "relative" layout so that some elements inside can be properly positioned. I can set the parent container to the "inline" if we want it to match the oggHandler layout. Would that fix what your issue is? or is it doing something else in your browser?

Maybe... Currently it persists.

mdale wrote:

doe the attached screen shot match your browser layout? Is that the issue your running into ?

My Firefox doesn't display the last millimeter or [yn‿aʁ.myʁ], so "‿" is totally invisible. Moreover, it can be worst for some others as the community insisted to remove it from the Common.js ASAP.

mdale wrote:

Should be fixed in r78977 ( will match oggHandler layout ) Will deploy this shortly.

mdale wrote:

Sorry I had not deployed the update yet ( a bunch of other updates got warped into this mwEmbed deployment, will do a blog post with full update info. )

If you view the console it should say "mwEmbed:remote: r183" or greater. ( once I deploy )

I will make a note on this bug once the deployment goes out.

mdale wrote:

update has gone out, once you shift refresh gadget should read "mwEmbed remote: r183" and should display properly...

but it appears http://fr.wiktionary.org/w/index.php?title=MediaWiki:Common.css has setup some style overrides. These don't work on "buttons" but do limit the mwEmbed based player just to the play button. This of course a bad idea, since it will apply to videos as well! ... if you want just the audio play button interface we could wrap the players in a specific class or set their width in the template ( mwEmbed should obey size requests)

but in the mean time I recommend removing those css rules in Common.css

I advised the community of this comment on the initial bug report: http://fr.wiktionary.org/wiki/Wiktionnaire:Wikid%C3%A9mie/d%C3%A9cembre_2010#lecteur_audio.

But if no other answer is left, I will study to propose a more recent discussion soon.