Page MenuHomePhabricator

Assign id="file" to image data cell in file history table
Closed, DeclinedPublic

Description

(File: ImagePage.php, line 979)

Please assign id="file" to the <td> for the thumbnail in the file history table. This will enable the application of a checkered background for the image in CSS.


Version: 1.17.x
Severity: enhancement

Details

Reference
bz26351

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:23 PM
bzimport set Reference to bz26351.
bzimport added a subscriber: Unknown Object (MLST).

Bryan.TongMinh wrote:

We can't do that, as ids are required to be unique. We can however add a CSS class.

How do you mean unique? Galleries has all image divs with id="file". Why can't it be done here?

Bryan.TongMinh wrote:

A certain id is only allowed to to occur once on a page per the HTML specification. Galleries do not have divs with the same id.

Bryan.TongMinh wrote:

On second thought, we don't even need to introduce a new class, as images in the filehistory can be styled with ".filehistory a img"

Oops, please close again... it automatically reopened.