Page MenuHomePhabricator

wfTimestamp() fed bogus time value: TYPE=1; VALUE=
Closed, ResolvedPublic

Description

Some part of the blocking code is feeding false or null into wfTimestamp on every page request.


Version: 1.18.x
Severity: normal

Details

Reference
bz26425

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:15 PM
bzimport set Reference to bz26425.
bzimport added a subscriber: Unknown Object (MLST).

Was caused by r71751, when the check for if the second argument to wfTimestamp is 0 changed from == to === sign. The constructor to Block has $this->mTimestamp = wfTimestamp( TS_MW, $timestamp ); in it, with $timestamp defaulting to '' if unspecified.

I'm not sure if wfTimestamp should be changed to use == so that '' == 0 or if Block::__construct should be changed to use 0 instead of '', or if both should be done.

fixed in r79013 (I changed the block constructor to use 0 instead of '')