Page MenuHomePhabricator

Unit tests do not work in all DB languages
Closed, ResolvedPublic

Description

Author: soxred93

Description:
As a result of the recent change to clone the DB structure for unit tests, there is a problem with SQLite, which is what tesla uses for its CI server. Because SQlite does not use DB prefixes, it cannot determine which tables to copy and which ones to drop. As a result, it tries to drop all the tables (not a good thing). The whole CloneDatabase thing needs to be rethunk; it's a major problem with no obvious solution.


Version: unspecified
Severity: minor

Details

Reference
bz26464

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:18 PM
bzimport set Reference to bz26464.

Drop stuff prefixed with parsertest_, then dupe the rest?

Can't we use a memory table for the SQLite target?

soxred93 wrote:

Fixed SQlite, which makes Tesla work again. Bumping importance down to minor.

I think these work w/o problem in SQLite.

soxred93 wrote:

It's just MySQL and SQLite that work.

I guess this issue can be closed now. DB cloning is way better now a day and works in MySQL / SQlite and Oracle. I am almost sure that works with PostgreSQL too.

So I am closing this bug which got eventually fixed this year.

Created attachment 10209
full phpunit.php log

Result of

LC_MESSAGES=C LANG=C LC_TIME=C php phpunit.php --configuration suite.xml --exclude-group Broken,Stub,ParserFuzz --log-junit $HOME/tests/log/postgres-log.xml

$wgSitename = "PostgresWiki";
$wgMetaNamespace = "Wikipedia";
$wgArticlePath = "/pg/wiki/$1";
$wgScriptPath = "/pg/w";
$wgScriptExtension = ".php";
$wgServer = "http://tools.wikimedia.pl";
$wgStylePath = "$wgScriptPath/skins";
$wgLogo = "$wgStylePath/common/images/wiki.png";
$wgEnableEmail = true;
$wgEnableUserEmail = true; # UPO
$wgEnotifUserTalk = true; # UPO
$wgEnotifWatchlist = true; # UPO
$wgEmailAuthentication = true;
$wgDBtype = "postgres";
$wgDBserver = "localhost";
$wgDBname = "trunk";
$wgDBport = "5432";
$wgDBmwschema = "mediawiki";
$wgEnableUploads = true;
$wgUseImageMagick = true;
$wgImageMagickConvertCommand = "/usr/bin/convert";
$wgUseInstantCommons = true;
$wgShellLocale = "en_US.utf8";
$wgLanguageCode = "pl";
$wgDefaultSkin = "vector";
$wgRightsPage = ""; # Set to the title of a wiki page that describes your license/copyright
$wgRightsUrl = "";
$wgRightsText = "";
$wgRightsIcon = "";
$wgDiff3 = "/usr/bin/diff3";
$wgResourceLoaderMaxQueryLength = -1;
require_once( "$IP/extensions/ParserFunctions/ParserFunctions.php" );
require_once( "$IP/extensions/Nuke/Nuke.php" );
$wgShowExceptionDetails = true;
$wgShowSQLErrors = true;
$wgShowDBErrorBacktrace = true;
$wgDebugDumpSql = true;
$wgDebugDBTransactions = true;

attachment pg-test-11 ignored as obsolete

Created attachment 10211
Proper full log from php-unit.php

Here is another log, the previous one was broken because of wrong php.ini settings.

There were 64 failures, because of canonical namespace names.

Wiki settings:

<?php

  1. This file was automatically generated by the MediaWiki 1.20alpha
  2. installer. If you make manual changes, please keep track in case you
  3. need to recreate them later. #
  4. See includes/DefaultSettings.php for all configurable settings
  5. and their default values, but don't forget to make changes in _this_
  6. file, not there. #
  7. Further documentation for configuration settings may be found at:
  8. http://www.mediawiki.org/wiki/Manual:Configuration_settings

Protect against web entry

if ( !defined( 'MEDIAWIKI' ) ) {
exit;
}

    1. Uncomment this to disable output compression
  1. $wgDisableOutputCompression = true;

$wgSitename = "/pg/wiki/\$1";

  1. The URL base path to the directory containing the wiki;
  2. defaults for all runtime URL paths are based off of this.
  3. For more information on customizing the URLs please see:
  4. http://www.mediawiki.org/wiki/Manual:Short_URL

$wgScriptPath = "/pg/w";
$wgScriptExtension = ".php";

The protocol and server name to use in fully-qualified URLs

$wgServer = "http://tools.wikimedia.pl";

The relative URL path to the skins directory

$wgStylePath = "$wgScriptPath/skins";

  1. The relative URL path to the logo. Make sure you change this from the default,
  2. or else you'll overwrite your logo when you upgrade!

$wgLogo = "$wgStylePath/common/images/wiki.png";

UPO means: this is also a user preference option

$wgEnableEmail = true;
$wgEnableUserEmail = true; # UPO

$wgEmergencyContact = "apache@localhost";
$wgPasswordSender = "apache@localhost";

$wgEnotifUserTalk = false; # UPO
$wgEnotifWatchlist = false; # UPO
$wgEmailAuthentication = true;

Database settings

$wgDBtype = "postgres";
$wgDBserver = "localhost";
$wgDBname = "minitest";
$wgDBuser = "wikiuser";
$wgDBpassword = "minitest";

Postgres specific settings

$wgDBport = "5432";
$wgDBmwschema = "mediawiki";

Shared memory settings

$wgMainCacheType = CACHE_NONE;
$wgMemCachedServers = array();

  1. To enable image uploads, make sure the 'images' directory
  2. is writable, then set this to true:

$wgEnableUploads = false;
$wgUseImageMagick = true;
$wgImageMagickConvertCommand = "/usr/bin/convert";

InstantCommons allows wiki to use images from http://commons.wikimedia.org

$wgUseInstantCommons = false;

  1. If you use ImageMagick (or any other shell command) on a
  2. Linux server, this will need to be set to the name of an
  3. available UTF-8 locale

$wgShellLocale = "en_US.utf8";

  1. If you want to use image uploads under safe mode,
  2. create the directories images/archive, images/thumb and
  3. images/temp, and make them all writable. Then uncomment
  4. this, if it's not already uncommented:

#$wgHashedUploadDirectory = false;

  1. Set $wgCacheDirectory to a writable directory on the web server
  2. to make your wiki go slightly faster. The directory should not
  3. be publically accessible from the web.

#$wgCacheDirectory = "$IP/cache";

Site language code, should be one of the list in ./languages/Names.php

$wgLanguageCode = "en";

$wgSecretKey = "c027029d286ed47d2203f9d078e76ad46ef927b42a1ba63ecd125eebcc37cd05";

  1. Site upgrade key. Must be set to a string (default provided) to turn on the
  2. web installer while LocalSettings.php is in place

$wgUpgradeKey = "4347204f166f4a00";

  1. Default skin: you can change the default skin. Use the internal symbolic
  2. names, ie 'standard', 'nostalgia', 'cologneblue', 'monobook', 'vector':

$wgDefaultSkin = "vector";

  1. For attaching licensing metadata to pages, and displaying an
  2. appropriate copyright notice / icon. GNU Free Documentation
  3. License and Creative Commons licenses are supported so far.

$wgRightsPage = ""; # Set to the title of a wiki page that describes your license/copyright
$wgRightsUrl = "";
$wgRightsText = "";
$wgRightsIcon = "";

Path to the GNU diff3 utility. Used for conflict resolution.

$wgDiff3 = "/usr/bin/diff3";

  1. Query string length limit for ResourceLoader. You should only set this if
  2. your web server has a query string length limit (then set it to that limit),
  3. or if you have suhosin.get.max_value_length set in php.ini (then set it to
  4. that value)

$wgResourceLoaderMaxQueryLength = -1;

  1. End of automatically generated settings.
  2. Add more configuration options below.

require_once( dirname( dirname( dirname( FILE ) ) ) ) . '/ExtraSettings.php';

ExtraSettings.php:

<?php
$wgArticlePath = "/pg/wiki/$1";
$wgSitename = "MiniTest";
if ( php_sapi_name() == 'cli' ) {
$wgDebugLogFile = "/tmp/{$wgSitename}.log";
}
$wgLanguageCode = "pl";

Attached:

Marcin, please open a new bug report.

Stupid me, refiled as r35204. Sorry for noise.