Remove use of PHP extract() function (use explicit assignment)
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Reedy
	Dec 30 2010, 2:53 AM

Description

extract() makes variables appear from nowhere, and should really be cleaned up in most (all?) cases to be made explicit.

Details

Reference: bz26496

	Subject	Repo	Branch	Lines +/-
	Don't suggest using extract()	mediawiki/core	master	+2 -2
	Replace extract() with explicit variable definitions in DjVuImage	mediawiki/core	master	+20 -42

Customize query in gerrit

Related Objects

Mentioned In: T180398: CodeSniffer to warn against usages of extract()
Mentioned Here: T180398: CodeSniffer to warn against usages of extract()

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM

• bzimport added a project: MediaWiki-General.

• bzimport set Reference to bz26496.

• bzimport added a subscriber: Unknown Object (MLST).

Reedy created this task.Dec 30 2010, 2:53 AM

Although $var->extract( calls were also matched, here's a resultspage that may be useful to see visualy:
http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=59&hash=808b5bef729e4547355d3c659d16a0dd#F5

ViewVC links in the right column.

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git&a=search&h=HEAD&st=grep&s=extract%28

Heh... it's a shame PHP doesn't have destructuring assignment for non-numeiric arrays/objects.

Krinkle renamed this task from extract() sucks (change for explicit definition) to PHP extract() sucks (change for explicit definition).Dec 10 2014, 2:12 PM

Krinkle updated the task description. (Show Details)

Krinkle added a project: Technical-Debt.

Krinkle set Security to None.

Krinkle removed a subscriber: Unknown Object (MLST).

Ricordisamoa subscribed.Sep 23 2015, 11:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2015, 11:15 PM

Change 271358 had a related patch set uploaded (by Ricordisamoa):
Replace extract() with explicit variable definitions in DjVuImage

https://gerrit.wikimedia.org/r/271358

gerritbot added a project: Patch-For-Review.Feb 17 2016, 9:43 PM

Change 271358 merged by jenkins-bot:
Replace extract() with explicit variable definitions in DjVuImage

https://gerrit.wikimedia.org/r/271358

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)).Aug 11 2016, 6:00 AM

In T28496#308003, @DanielFriesen wrote:

Heh... it's a shame PHP doesn't have destructuring assignment for non-numeiric arrays/objects.

https://wiki.php.net/rfc/list_keys has been implemented in PHP 7.1

So instead of

$arr = unpack( 'a4magic/a4chunk/NchunkLength', $header );
$chunk = $arr['chunk'];
$chunkLength = $arr['chunkLength'];

you should be able to write

[ 'chunk' => $chunk, 'chunkLength' => $chunkLength ] = unpack( 'a4magic/a4chunk/NchunkLength', $header );

Ricordisamoa removed a project: Patch-For-Review.Jan 10 2017, 5:49 PM

Reedy mentioned this in T180398: CodeSniffer to warn against usages of extract().Nov 13 2017, 8:06 PM

Krinkle renamed this task from PHP extract() sucks (change for explicit definition) to Remove use of PHP extract() function (use explicit assignment).Dec 27 2017, 9:16 PM

Krinkle removed projects: MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), MW-1.28-release-notes.

Krinkle moved this task from Unsorted to Needs refactor on the Technical-Debt board.

Change 413937 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] Don't suggest using extract()

https://gerrit.wikimedia.org/r/413937

gerritbot added a project: Patch-For-Review.Feb 24 2018, 1:42 AM

Change 413937 merged by jenkins-bot:
[mediawiki/core@master] Don't suggest using extract()

https://gerrit.wikimedia.org/r/413937

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 24 2018, 3:00 AM

https://codesearch.wmflabs.org/search/?q=%5B%5E%3E%5Dextract%5C(&i=nope&files=%5C.php%24&repos= is not terribly encouraging.

matej_suchanek removed a project: Patch-For-Review.Jan 31 2019, 7:18 PM

matej_suchanek added a project: TestMe.Jun 6 2019, 10:52 AM

In T28496#4176947, @Jdforrester-WMF wrote:

https://codesearch.wmflabs.org/search/?q=%5B%5E%3E%5Dextract%5C(&i=nope&files=%5C.php%24&repos= is not terribly encouraging.

The few calls are either for tests or $GLOBALS (and mostly a combination of both) or false positives of methods called extract. MediaWiki-Codesniffer bans usage of extract anyways. (T180398)

Yeah, well done all for the fixes in the past three years. :-)

Remove use of PHP extract() function (use explicit assignment)Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Remove use of PHP extract() function (use explicit assignment)
Closed, ResolvedPublic
Actions