Page MenuHomePhabricator

imagelinks not updated for cascade protection
Closed, ResolvedPublic

Description

Cascadeprotection of images working with the imagelinks (see Title::getCascadeProtectionSources).

But when there are no templatelinks changes after a purge the method doCascadeProtectionUpdates does not start a LinksUpdate even imagelinks are changed.

Thanks.


Version: 1.18.x
Severity: enhancement

Details

Reference
bz26503

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:21 PM
bzimport set Reference to bz26503.
bzimport added a subscriber: Unknown Object (MLST).

When a cascade protected page contains time-dependent imagelinks than the imagelinks table is not updated after a purge of the cascade protected page and so the wrong image is cascade protected.

It works when there are also templatelinks to update, because Article::doCascadeProtectionUpdates handles the special case of time-dependent transclusion of templates. It is called when the html page is parsed the first time after the purge.

Change 105830 had a related patch set uploaded by Anomie:
Make imagelinks work like templatelinks

https://gerrit.wikimedia.org/r/105830

Change 105830 merged by jenkins-bot:
Make imagelinks work like templatelinks

https://gerrit.wikimedia.org/r/105830

Should be deployed to WMF wikis with 1.23wmf10, see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.