Page MenuHomePhabricator

let action=parse&prop=languageshtml return the right html
Closed, InvalidPublic

Description

The prop languageshtml returns the html for the otherlanguages section. But this section is in the most skin a html list and not a pipe seperator list.

It is possible to have a html list in that skins where it is a html list? (MonoBookTemplate (includes Skins MonoBook, Modern, Chick, Simple, MySkin) and VectorTemplate (includes Vector skin))

Thanks.


Version: 1.18.x
Severity: enhancement

Details

Reference
bz26514

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:21 PM
bzimport set Reference to bz26514.
bzimport added a subscriber: Unknown Object (MLST).

CC'd Priyanka

Added in r77896

+ private function categoriesHtml( $categories ) {
+ global $wgOut, $wgUser;
+ $wgOut->addCategoryLinks( $categories );
+ $sk = $wgUser->getSkin();
+ return $sk->getCategories();
+ }

Surely that does what you're asking for...?

Unless there's some extra skin parsing somewhere along the way

It is the following (languagesHtml, not categoriesHtml):

+ private function languagesHtml( $languages ) {
+ global $wgOut, $wgUser;
+ $wgOut->setLanguageLinks( $languages );
+ $sk = $wgUser->getSkin();
+ return $sk->otherLanguages();
+ }

The function is not right for MonoBookTemplate and VectorTemplate, because there it is done at another place, not by overriding otherLanguages.

languageshtml was deprecated with gerrit 96364, so no need to fix this anymore.